🔃 [EngCom] Public Pull Requests - 2.2-develop

Accepted Public Pull Requests:
 - magento#18658: [Backport] MAGENTO-18131: Fixed EAV attributes values query (by @gelanivishal)
 - magento#18670: Remove unnecessary class import, see magento#18280 (by @sreichel)
 - magento#16915: magento#14510: Creating custom customer attribute with default value 0 will cause not saving value for customer entity. (by @swnsma)
 - magento#18566: Module Catalog URL Rewrite: fix issue with product URL Rewrites re-generation after changing product URL Key for product with existing url_path attribute value (by @oleksii-lisovyi)
 - magento#18563: [Backport] Update CategoryProcessor.php (by @gelanivishal)


Fixed GitHub Issues:
 - magento#18131: Entity Type ID at Join (reported by @akimatze) has been fixed in magento#18658 by @gelanivishal in 2.2-develop branch
   Related commits:
     1. 53a06a9

 - magento#14510: Creating custom customer attribute with default value 0 will cause not saving value for customer entity (reported by @victortodoran) has been fixed in magento#16915 by @swnsma in 2.2-develop branch
   Related commits:
     1. 5fa4d5f
     2. 0698aa6
     3. c106a62

 - magento#5929: Saving Product does not update URL rewrite in Magento 2.1.0 (reported by @JacobDrummond) has been fixed in magento#18566 by @oleksii-lisovyi in 2.2-develop branch
   Related commits:
     1. 7169f04
     2. 9b0586e

 - magento#18532: Module Catalog: product "Save and Duplicate" causes getting infinite loop (reported by @oleksii-lisovyi) has been fixed in magento#18566 by @oleksii-lisovyi in 2.2-develop branch
   Related commits:
     1. 7169f04
     2. 9b0586e

 - magento#18234: Product Import -> Upsert Category: Url Rewrites are just created for default website (reported by @ulftietze) has been fixed in magento#18563 by @gelanivishal in 2.2-develop branch
   Related commits:
     1. e2f89c8
     2. 4ad4849

Author: magento-engcom-team

app/code/Magento/Catalog/Model/Product/Attribute/Backend/Boolean.php

@@ -25,7 +25,9 @@ public function beforeSave($object)
         $attributeCode = $this->getAttribute()->getName();
         if ($object->getData('use_config_' . $attributeCode)) {
             $object->setData($attributeCode, BooleanSource::VALUE_USE_CONFIG);
+            return $this;
         }
-        return $this;
+
+        return parent::beforeSave($object);
     }
 }

app/code/Magento/CatalogImportExport/Model/Import/Product/CategoryProcessor.php

@@ -66,6 +66,8 @@ public function __construct(
     }
 
     /**
+     * Initialize categories to be processed
+     *
      * @return $this
      */
     protected function initCategories()
@@ -112,6 +114,9 @@ protected function createCategory($name, $parentId)
         if (!($parentCategory = $this->getCategoryById($parentId))) {
             $parentCategory = $this->categoryFactory->create()->load($parentId);
         }
+        
+        // Set StoreId to 0 to generate URL Keys global and prevent generating url rewrites just for default website
+        $category->setStoreId(0);
         $category->setPath($parentCategory->getPath());
         $category->setParentId($parentId);
         $category->setName($name);

app/code/Magento/CatalogUrlRewrite/Observer/ProductProcessUrlRewriteSavingObserver.php

@@ -6,11 +6,15 @@
 namespace Magento\CatalogUrlRewrite\Observer;
 
 use Magento\Catalog\Model\Product;
+use Magento\CatalogUrlRewrite\Model\ProductUrlPathGenerator;
 use Magento\CatalogUrlRewrite\Model\ProductUrlRewriteGenerator;
+use Magento\Framework\App\ObjectManager;
 use Magento\UrlRewrite\Model\UrlPersistInterface;
-use Magento\UrlRewrite\Service\V1\Data\UrlRewrite;
 use Magento\Framework\Event\ObserverInterface;
 
+/**
+ * Class ProductProcessUrlRewriteSavingObserver
+ */
 class ProductProcessUrlRewriteSavingObserver implements ObserverInterface
 {
     /**
@@ -23,22 +27,33 @@ class ProductProcessUrlRewriteSavingObserver implements ObserverInterface
      */
     private $urlPersist;
 
+    /**
+     * @var ProductUrlPathGenerator
+     */
+    private $productUrlPathGenerator;
+
     /**
      * @param ProductUrlRewriteGenerator $productUrlRewriteGenerator
      * @param UrlPersistInterface $urlPersist
+     * @param ProductUrlPathGenerator|null $productUrlPathGenerator
      */
     public function __construct(
         ProductUrlRewriteGenerator $productUrlRewriteGenerator,
-        UrlPersistInterface $urlPersist
+        UrlPersistInterface $urlPersist,
+        ProductUrlPathGenerator $productUrlPathGenerator = null
     ) {
         $this->productUrlRewriteGenerator = $productUrlRewriteGenerator;
         $this->urlPersist = $urlPersist;
+        $this->productUrlPathGenerator = $productUrlPathGenerator ?: ObjectManager::getInstance()
+            ->get(ProductUrlPathGenerator::class);
     }
 
     /**
      * Generate urls for UrlRewrite and save it in storage
+     *
      * @param \Magento\Framework\Event\Observer $observer
      * @return void
+     * @throws \Magento\UrlRewrite\Model\Exception\UrlAlreadyExistsException
      */
     public function execute(\Magento\Framework\Event\Observer $observer)
     {
@@ -51,6 +66,8 @@ public function execute(\Magento\Framework\Event\Observer $observer)
             || $product->dataHasChangedFor('visibility')
         ) {
             if ($product->isVisibleInSiteVisibility()) {
+                $product->unsUrlPath();
+                $product->setUrlPath($this->productUrlPathGenerator->getUrlPath($product));
                 $this->urlPersist->replace($this->productUrlRewriteGenerator->generate($product));
             }
         }

app/code/Magento/Customer/Model/GroupManagement.php

@@ -15,7 +15,6 @@
 use Magento\Framework\Api\SortOrderBuilder;
 use Magento\Framework\App\Config\ScopeConfigInterface;
 use Magento\Framework\App\ObjectManager;
-use Magento\Framework\Data\Collection;
 use Magento\Framework\Exception\NoSuchEntityException;
 use Magento\Store\Model\StoreManagerInterface;
 
@@ -170,7 +169,7 @@ public function getLoggedInGroups()
             ->create();
         $groupNameSortOrder = $this->sortOrderBuilder
             ->setField('customer_group_code')
-            ->setDirection(Collection::SORT_ORDER_ASC)
+            ->setAscendingDirection()
             ->create();
         $searchCriteria = $this->searchCriteriaBuilder
             ->addFilters($notLoggedInFilter)

app/code/Magento/Downloadable/Setup/UpgradeData.php

@@ -0,0 +1,58 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Downloadable\Setup;
+
+use Magento\Eav\Setup\EavSetup;
+use Magento\Eav\Setup\EavSetupFactory;
+use Magento\Framework\Setup\ModuleDataSetupInterface;
+use Magento\Framework\Setup\UpgradeDataInterface;
+use Magento\Framework\Setup\ModuleContextInterface;
+
+/**
+ * @codeCoverageIgnore
+ */
+class UpgradeData implements UpgradeDataInterface
+{
+    /**
+     * EAV setup factory
+     *
+     * @var EavSetupFactory
+     */
+    private $eavSetupFactory;
+
+    /**
+     * Init
+     *
+     * @param EavSetupFactory $eavSetupFactory
+     */
+    public function __construct(EavSetupFactory $eavSetupFactory)
+    {
+        $this->eavSetupFactory = $eavSetupFactory;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function upgrade(ModuleDataSetupInterface $setup, ModuleContextInterface $context)
+    {
+        $setup->startSetup();
+
+        if (version_compare($context->getVersion(), '2.0.3', '<')) {
+            /** @var EavSetup $eavSetup */
+            $eavSetup = $this->eavSetupFactory->create(['setup' => $setup]);
+            // remove default value
+            $eavSetup->updateAttribute(
+                \Magento\Catalog\Model\Product::ENTITY,
+                'links_exist',
+                'default_value',
+                null
+            );
+        }
+
+        $setup->endSetup();
+    }
+}

app/code/Magento/Downloadable/etc/module.xml

@@ -6,7 +6,7 @@
  */
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module name="Magento_Downloadable" setup_version="2.0.2">
+    <module name="Magento_Downloadable" setup_version="2.0.3">
         <sequence>
             <module name="Magento_Catalog"/>
         </sequence>

app/code/Magento/Eav/Model/Entity/Attribute/AbstractAttribute.php

@@ -392,7 +392,7 @@ public function getIsVisibleOnFront()
     }
 
     /**
-     * @return string|int|bool|float
+     * @return string|null
      * @codeCoverageIgnore
      */
     public function getDefaultValue()

app/code/Magento/Eav/Model/Entity/Attribute/Backend/AbstractBackend.php

@@ -203,12 +203,12 @@ public function getEntityValueId($entity)
     /**
      * Retrieve default value
      *
-     * @return mixed
+     * @return string
      */
     public function getDefaultValue()
     {
         if ($this->_defaultValue === null) {
-            if ($this->getAttribute()->getDefaultValue()) {
+            if ($this->getAttribute()->getDefaultValue() !== null) {
                 $this->_defaultValue = $this->getAttribute()->getDefaultValue();
             } else {
                 $this->_defaultValue = "";
@@ -280,7 +280,7 @@ public function afterLoad($object)
     public function beforeSave($object)
     {
         $attrCode = $this->getAttribute()->getAttributeCode();
-        if (!$object->hasData($attrCode) && $this->getDefaultValue()) {
+        if (!$object->hasData($attrCode) && $this->getDefaultValue() !== '') {
             $object->setData($attrCode, $this->getDefaultValue());
         }
 

app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php

@@ -1233,7 +1233,7 @@ protected function _getLoadAttributesSelect($table, $attributeIds = [])
 
         if ($entity->getEntityTable() == \Magento\Eav\Model\Entity::DEFAULT_ENTITY_TABLE && $entity->getTypeId()) {
             $select->where(
-                'entity_type_id =?',
+                't_d.entity_type_id =?',
                 $entity->getTypeId()
             );
         }