Skip to content

Commit fd7b1ec

Browse files
committed
Removed potentially-misleading dead code and comment
Since ptr is being passed by value to the lambda expression, setting ptr to null will have no effect past that single line. The combination of the code and the comment which implies there is an additional benefit/security in doing so might mislead a maintainer or developer down the road.
1 parent ee1654e commit fd7b1ec

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

hdr/sqlite_modern_cpp.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,8 +280,8 @@ namespace sqlite {
280280
sqlite3* tmp = nullptr;
281281
auto ret = sqlite3_open16(db_name.data(), &tmp);
282282
if(ret != SQLITE_OK) exceptions::throw_sqlite_error(ret);
283-
_db = std::shared_ptr<sqlite3>(tmp, [=](sqlite3* ptr) { sqlite3_close_v2(ptr); ptr = nullptr; }); // close and null to be sure
284-
//_db.reset(tmp, sqlite3_close); // alternative close. (faster?)
283+
_db = std::shared_ptr<sqlite3>(tmp, [=](sqlite3* ptr) { sqlite3_close_v2(ptr); });
284+
//_db.reset(tmp, sqlite3_close); // alternative close. (faster?)
285285
}
286286

287287
database(std::string const & db_name):

0 commit comments

Comments
 (0)