Skip to content

Tqct 1058 fix warnings #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Oct 23, 2024
Merged

Tqct 1058 fix warnings #257

merged 21 commits into from
Oct 23, 2024

Conversation

@alubenskyi
Copy link
Contributor

@alubenskyi alubenskyi commented Oct 23, 2024

No description provided.

@DmitryMasley DmitryMasley mentioned this pull request Oct 23, 2024
Open
rischenko
rischenko reviewed Oct 23, 2024
View reviewed changes
spec/translation_quality/checks/insertable_consistency.yaml Outdated
description: check subtype code
example: "INSERTABLE_ADDED"
severityLevelCode:
type: string
Copy link

@rischenko rischenko Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref to tqc_common#severityLevelCodeEnum ?

Copy link
Contributor Author

@alubenskyi alubenskyi Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

rischenko
rischenko reviewed Oct 23, 2024
View reviewed changes
spec/translation_quality/checks/insertable_consistency.yaml Outdated
example: "INSERTABLE_ADDED"
severityLevelCode:
nullable: true
type: string
Copy link

@rischenko rischenko Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref?

Copy link
Contributor Author

@alubenskyi alubenskyi Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

rischenko
rischenko reviewed Oct 23, 2024
View reviewed changes
spec/translation_quality/checks/non_translatable_text.yaml Outdated
severityLevelCode:
nullable: true
type: string
enum:
Copy link

@rischenko rischenko Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref?

Copy link
Contributor Author

@alubenskyi alubenskyi Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

rischenko
rischenko reviewed Oct 23, 2024
View reviewed changes
spec/translation_quality/checks/non_translatable_text.yaml Outdated
severityLevelCode:
nullable: true
type: string
enum:
Copy link

@rischenko rischenko Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref

Copy link
Contributor Author

@alubenskyi alubenskyi Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

rischenko
rischenko reviewed Oct 23, 2024
View reviewed changes
spec/translation_quality/checks/number_consistency.yaml Outdated
example: "NUMBER_ADDED"
severityLevelCode:
type: string
enum:
Copy link

@rischenko rischenko Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref

Copy link
Contributor Author

@alubenskyi alubenskyi Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

rischenko
rischenko reviewed Oct 23, 2024
View reviewed changes
spec/translation_quality/checks/number_consistency.yaml Outdated
severityLevelCode:
nullable: true
type: string
enum:
Copy link

@rischenko rischenko Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref

Copy link
Contributor Author

@alubenskyi alubenskyi Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

rischenko
rischenko reviewed Oct 23, 2024
View reviewed changes
spec/translation_quality/checks/regex_check.yaml Outdated
- ref: '../tqc_common.yaml#/components/schemas/regexRuleWithRuleUid'
type: object
nullable: true
oneOf:
Copy link

@rischenko rischenko Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need oneOf?

Copy link
Contributor Author

@alubenskyi alubenskyi Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

rischenko
rischenko reviewed Oct 23, 2024
View reviewed changes
spec/translation_quality/checks/segment_completeness.yaml Outdated
example: "TARGET_IS_EMPTY"
severityLevelCode:
type: string
enum:
Copy link

@rischenko rischenko Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref

Copy link
Contributor Author

@alubenskyi alubenskyi Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

rischenko
rischenko reviewed Oct 23, 2024
View reviewed changes
spec/translation_quality/checks/segment_completeness.yaml Outdated
severityLevelCode:
nullable: true
type: string
enum:
Copy link

@rischenko rischenko Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref

Copy link
Contributor Author

@alubenskyi alubenskyi Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

rischenko
rischenko reviewed Oct 23, 2024
View reviewed changes
spec/translation_quality/checks/tag_consistency.yaml Outdated
severityLevelCode:
nullable: true
type: string
enum:
Copy link

@rischenko rischenko Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref

Copy link
Contributor Author

@alubenskyi alubenskyi Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

rischenko
rischenko reviewed Oct 23, 2024
View reviewed changes
spec/translation_quality/checks/tag_consistency.yaml Outdated
severityLevelCode:
nullable: true
type: string
enum:
Copy link

@rischenko rischenko Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref

Copy link
Contributor Author

@alubenskyi alubenskyi Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

rischenko
rischenko reviewed Oct 23, 2024
View reviewed changes
rischenko
rischenko reviewed Oct 23, 2024
View reviewed changes
rischenko
rischenko reviewed Oct 23, 2024
View reviewed changes
spec/translation_quality/checks/target_source_consistency.yaml Outdated
example: "SAME_SOURCE_DIFFERENT_TRANSLATIONS"
severityLevelCode:
type: string
enum:
Copy link

@rischenko rischenko Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref

Copy link
Contributor Author

@alubenskyi alubenskyi Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

rischenko
rischenko reviewed Oct 23, 2024
View reviewed changes
spec/translation_quality/checks/target_source_consistency.yaml Outdated
example: "SAME_SOURCE_DIFFERENT_TRANSLATIONS"
severityLevelCode:
type: string
enum:
Copy link

@rischenko rischenko Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref

Copy link
Contributor Author

@alubenskyi alubenskyi Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@alubenskyi alubenskyi merged commit 6b6e3ce into TCM-5257-Summarize-issues-with-swagger-api-documentation-for-creating-sdk Oct 23, 2024
1 check passed
@alubenskyi alubenskyi deleted the TQCT-1058-fix-warnings branch October 23, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexArcher AlexArcher AlexArcher approved these changes

@DmitryMasley DmitryMasley DmitryMasley approved these changes

@rischenko rischenko rischenko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alubenskyi @AlexArcher @DmitryMasley @rischenko