From 13a3865c2f98bbcc8aba009efc38f3abe32a0a09 Mon Sep 17 00:00:00 2001 From: Benno Stein Date: Thu, 28 Nov 2024 14:23:09 +0000 Subject: [PATCH] Make `resources` field non-optional on SkipService --- skipruntime-ts/api/src/api.ts | 2 +- .../wasm/src/internals/skipruntime_module.ts | 20 +++++++++---------- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/skipruntime-ts/api/src/api.ts b/skipruntime-ts/api/src/api.ts index c865303eb..ef2f4da7c 100644 --- a/skipruntime-ts/api/src/api.ts +++ b/skipruntime-ts/api/src/api.ts @@ -388,7 +388,7 @@ export interface SkipService< /** The external service dependencies of the service */ externalServices?: { [name: string]: ExternalService }; /** The reactive resources which compose the public interface of this reactive service */ - resources?: { + resources: { [name: string]: new (params: { [param: string]: string; }) => Resource; diff --git a/skipruntime-ts/wasm/src/internals/skipruntime_module.ts b/skipruntime-ts/wasm/src/internals/skipruntime_module.ts index 0103f710e..078dc7ef9 100644 --- a/skipruntime-ts/wasm/src/internals/skipruntime_module.ts +++ b/skipruntime-ts/wasm/src/internals/skipruntime_module.ts @@ -891,17 +891,15 @@ class LinksImpl implements Links { } const skresources = this.fromWasm.SkipRuntime_ResourceBuilderMap__create(); - if (service.resources) { - for (const [name, builder] of Object.entries(service.resources)) { - const skbuilder = this.fromWasm.SkipRuntime_createResourceBuilder( - this.handles.register(new ResourceBuilder(builder)), - ); - this.fromWasm.SkipRuntime_ResourceBuilderMap__add( - skresources, - skjson.exportString(name), - skbuilder, - ); - } + for (const [name, builder] of Object.entries(service.resources)) { + const skbuilder = this.fromWasm.SkipRuntime_createResourceBuilder( + this.handles.register(new ResourceBuilder(builder)), + ); + this.fromWasm.SkipRuntime_ResourceBuilderMap__add( + skresources, + skjson.exportString(name), + skbuilder, + ); } const skservice = this.fromWasm.SkipRuntime_createService( this.handles.register(service),