Skip to content

Commit e11f506

Browse files
committed
cleanup
1 parent 60f7b52 commit e11f506

File tree

6 files changed

+7
-22
lines changed

6 files changed

+7
-22
lines changed

packages/sqlite_async/lib/src/common/sqlite_database.dart

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,6 @@ abstract class SqliteDatabase
5151
/// The maximum number of concurrent read transactions if not explicitly specified.
5252
static const int defaultMaxReaders = 5;
5353

54-
int get numConnections;
55-
List<SqliteConnection> getAllConnections();
56-
5754
/// Open a SqliteDatabase.
5855
///
5956
/// Only a single SqliteDatabase per [path] should be opened at a time.
@@ -106,4 +103,9 @@ abstract class SqliteDatabase
106103
factory SqliteDatabase.singleConnection(SqliteConnection connection) {
107104
return SingleConnectionDatabase(connection);
108105
}
106+
107+
/// Returns a list of all the connections (read and write) managed by this database.
108+
/// This can be useful to run the same statement on all connections. For instance,
109+
/// ATTACHing a database, that is expected to be available in all connections.
110+
List<SqliteConnection> getAllConnections();
109111
}

packages/sqlite_async/lib/src/impl/single_connection_database.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,4 @@ final class SingleConnectionDatabase
6262
List<SqliteConnection> getAllConnections() {
6363
return [connection];
6464
}
65-
66-
@override
67-
int get numConnections => 1;
6865
}

packages/sqlite_async/lib/src/impl/stub_sqlite_database.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,6 @@ class SqliteDatabaseImpl
6565
throw UnimplementedError();
6666
}
6767

68-
@override
69-
int get numConnections => throw UnimplementedError();
70-
7168
@override
7269
List<SqliteConnection> getAllConnections() {
7370
throw UnimplementedError();

packages/sqlite_async/lib/src/native/database/native_sqlite_database.dart

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,10 +171,7 @@ class SqliteDatabaseImpl
171171
Future<void> refreshSchema() {
172172
return _pool.refreshSchema();
173173
}
174-
175-
@override
176-
int get numConnections => _pool.getNumConnections();
177-
174+
178175
@override
179176
List<SqliteConnection> getAllConnections() {
180177
return _pool.getAllConnections();

packages/sqlite_async/lib/src/web/database.dart

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -177,15 +177,11 @@ class WebDatabase
177177
await isInitialized;
178178
return _database.fileSystem.flush();
179179
}
180-
@override
181-
int get numConnections => throw UnimplementedError();
182-
183180

184181
@override
185182
List<SqliteConnection> getAllConnections() {
186-
throw UnimplementedError();
183+
return [this];
187184
}
188-
189185
}
190186

191187
class _SharedContext implements SqliteReadContext {

packages/sqlite_async/lib/src/web/database/web_sqlite_database.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -180,13 +180,9 @@ class SqliteDatabaseImpl
180180
Future<WebDatabaseEndpoint> exposeEndpoint() async {
181181
return await _connection.exposeEndpoint();
182182
}
183-
@override
184-
int get numConnections => 1;
185183

186184
@override
187185
List<SqliteConnection> getAllConnections() {
188186
return [_connection];
189187
}
190-
191-
192188
}

0 commit comments

Comments
 (0)