Skip to content

Commit 384f2a7

Browse files
committed
remove getter
1 parent fe0b71d commit 384f2a7

File tree

8 files changed

+15
-44
lines changed

8 files changed

+15
-44
lines changed

packages/sqlite_async/lib/src/common/sqlite_database.dart

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ mixin SqliteDatabaseMixin implements SqliteConnection, SqliteQueries {
4141
IsolateConnectionFactory isolateConnectionFactory();
4242

4343
/// Locks all underlying connections making up this database, and gives [block] access to all of them at once.
44+
/// This can be useful to run the same statement on all connections. For instance,
45+
/// ATTACHing a database, that is expected to be available in all connections.
4446
Future<T> withAllConnections<T>(
4547
Future<T> Function(
4648
SqliteWriteContext writer, List<SqliteReadContext> readers)
@@ -109,9 +111,4 @@ abstract class SqliteDatabase
109111
factory SqliteDatabase.singleConnection(SqliteConnection connection) {
110112
return SingleConnectionDatabase(connection);
111113
}
112-
113-
/// Returns a list of all the connections (read and write) managed by this database.
114-
/// This can be useful to run the same statement on all connections. For instance,
115-
/// ATTACHing a database, that is expected to be available in all connections.
116-
List<SqliteConnection> get allConnections;
117114
}

packages/sqlite_async/lib/src/impl/single_connection_database.dart

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,10 @@ final class SingleConnectionDatabase
5959
}
6060

6161
@override
62-
List<SqliteConnection> get allConnections {
63-
return [connection];
64-
}
65-
66-
@override
67-
Future<T> withAllConnections<T>(Future<T> Function(SqliteWriteContext writer, List<SqliteReadContext> readers) block) {
62+
Future<T> withAllConnections<T>(
63+
Future<T> Function(
64+
SqliteWriteContext writer, List<SqliteReadContext> readers)
65+
block) {
6866
return writeLock((_) => block(connection, []));
6967
}
7068
}

packages/sqlite_async/lib/src/impl/stub_sqlite_database.dart

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,10 @@ class SqliteDatabaseImpl
6666
}
6767

6868
@override
69-
List<SqliteConnection> get allConnections {
70-
throw UnimplementedError();
71-
}
72-
73-
@override
74-
Future<T> withAllConnections<T>(Future<T> Function(SqliteWriteContext writer, List<SqliteReadContext> readers) block) {
69+
Future<T> withAllConnections<T>(
70+
Future<T> Function(
71+
SqliteWriteContext writer, List<SqliteReadContext> readers)
72+
block) {
7573
throw UnimplementedError();
7674
}
7775
}

packages/sqlite_async/lib/src/native/database/connection_pool.dart

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -233,15 +233,6 @@ class SqliteConnectionPool with SqliteQueries implements SqliteConnection {
233233
}
234234
}
235235

236-
List<SqliteConnection> get allConnections {
237-
final connections = <SqliteConnection>[];
238-
if (_writeConnection != null) {
239-
connections.add(_writeConnection!);
240-
}
241-
connections.addAll(_allReadConnections);
242-
return connections;
243-
}
244-
245236
Future<T> withAllConnections<T>(
246237
Future<T> Function(
247238
SqliteWriteContext writer, List<SqliteReadContext> readers)

packages/sqlite_async/lib/src/native/database/native_sqlite_database.dart

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -171,14 +171,12 @@ class SqliteDatabaseImpl
171171
Future<void> refreshSchema() {
172172
return _pool.refreshSchema();
173173
}
174-
175-
@override
176-
List<SqliteConnection> get allConnections {
177-
return _pool.allConnections;
178-
}
179-
174+
180175
@override
181-
Future<T> withAllConnections<T>(Future<T> Function(SqliteWriteContext writer, List<SqliteReadContext> readers) block) {
176+
Future<T> withAllConnections<T>(
177+
Future<T> Function(
178+
SqliteWriteContext writer, List<SqliteReadContext> readers)
179+
block) {
182180
return _pool.withAllConnections(block);
183181
}
184182
}

packages/sqlite_async/lib/src/web/database.dart

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -172,11 +172,6 @@ class WebDatabase
172172
return _database.fileSystem.flush();
173173
}
174174

175-
@override
176-
List<SqliteConnection> get allConnections {
177-
return [this];
178-
}
179-
180175
@override
181176
Future<T> withAllConnections<T>(
182177
Future<T> Function(

packages/sqlite_async/lib/src/web/database/web_sqlite_database.dart

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -179,11 +179,6 @@ class SqliteDatabaseImpl
179179
return await _connection.exposeEndpoint();
180180
}
181181

182-
@override
183-
List<SqliteConnection> get allConnections {
184-
return [_connection];
185-
}
186-
187182
@override
188183
Future<T> withAllConnections<T>(
189184
Future<T> Function(

packages/sqlite_async/test/native/basic_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ void main() {
7878
await db.initialize();
7979
await createTables(db);
8080

81-
8281
Future<Row> readWithRandomDelay(SqliteReadContext ctx, int id) async {
8382
return await ctx.get(
8483
'SELECT ? as i, test_sleep(?) as sleep, test_connection_name() as connection',

0 commit comments

Comments
 (0)