json serialization - bug fixed

Author: jyothish6190

sift/client.py

@@ -2,12 +2,13 @@
 See: https://siftscience.com/docs/references/events-api
 """
 
+import decimal
 import json
 import requests
 import requests.auth
 import sys
 if sys.version_info[0] < 3:
-    import urllib.request, urllib.parse, urllib.error
+    import six.moves.urllib as urllib 
     _UNICODE_STRING = str
 else:
     import urllib.parse
@@ -26,6 +27,11 @@ def _quote_path(s):
     # optional arg to override this
     return urllib.parse.quote(s, '')
 
+class DecimalEncoder(json.JSONEncoder):
+    def default(self, o):
+        if isinstance(o, decimal.Decimal):
+            return (str(o),)
+        return super(DecimalEncoder, self).default(o)
 
 class Client(object):
 
@@ -158,7 +164,7 @@ def track(
         try:
             response = self.session.post(
                 path,
-                data=json.dumps(properties),
+                data=json.dumps(properties, cls=DecimalEncoder),
                 headers=headers,
                 timeout=timeout,
                 params=params)

tests/test_client.py

@@ -1,4 +1,5 @@
 import datetime
+from decimal import Decimal
 import warnings
 import json
 import mock
@@ -7,7 +8,7 @@
 import sys
 import requests.exceptions
 if sys.version_info[0] < 3:
-    import urllib.request, urllib.parse, urllib.error
+    import six.moves.urllib as urllib 
 else:
     import urllib.parse
 
@@ -16,7 +17,7 @@ def valid_transaction_properties():
     return {
         '$buyer_user_id': '123456',
         '$seller_user_id': '654321',
-        '$amount': 1253200,
+        '$amount': Decimal('1253200.0'),
         '$currency_code': 'USD',
         '$time': int(datetime.datetime.now().strftime('%s')),
         '$transaction_id': 'my_transaction_id',

tests/test_client_v203.py

@@ -1,4 +1,5 @@
 import datetime
+from decimal import Decimal
 import warnings
 import json
 import mock
@@ -7,7 +8,7 @@
 import sys
 import requests.exceptions
 if sys.version_info[0] < 3:
-    import urllib.request, urllib.parse, urllib.error
+    import six.moves.urllib as urllib 
 else:
     import urllib.parse
 
@@ -16,7 +17,7 @@ def valid_transaction_properties():
     return {
         '$buyer_user_id': '123456',
         '$seller_user_id': '654321',
-        '$amount': 1253200,
+        '$amount': Decimal('1253200.0'),
         '$currency_code': 'USD',
         '$time': int(datetime.datetime.now().strftime('%s')),
         '$transaction_id': 'my_transaction_id',