fix fieldNameSeen and add test to catch mistakes in future

Author: Wesley Ellis

codegen/lib/graphql_java_gen/templates/APISchema.java.erb

@@ -295,7 +295,7 @@ public class <%= schema_name %> {
 
                   public <%= type.name %> set<%= field.classify_name %>(<%= java_annotations(field, in_argument: true) %><%= java_input_type(field.type) %> <%= escape_reserved_word(field.camelize_name) %>) {
                       this.<%= escape_reserved_word(field.camelize_name) %> = <%= escape_reserved_word(field.camelize_name) %>;
-                      this.<%= escape_reserved_word(field.name) %>Seen = true;
+                      this.<%= field.camelize_name %>Seen = true;
                       return this;
                   }
                 <% end %>
@@ -310,7 +310,7 @@ public class <%= schema_name %> {
                     <%= generate_build_input_code(escape_reserved_word(field.camelize_name), field.type) %>
                   <% end %>
                   <% type.optional_input_fields.each do |field| %>
-                    if (this.<%= escape_reserved_word(field.name) %>Seen) {
+                    if (this.<%= field.camelize_name %>Seen) {
                       _queryBuilder.append(separator);
                       separator = ",";
                       _queryBuilder.append("<%= field.name %>:");

codegen/test/support/schema.rb

@@ -91,6 +91,7 @@ module Schema
       argument :value, !types.Int
       argument :ttl, TimeType
       argument :negate, types.Boolean, default_value: false
+      argument :api_client, types.String
     end
 
     MutationType = GraphQL::ObjectType.define do

support/src/test/java/com/shopify/graphql/support/Generated.java

@@ -1082,6 +1082,9 @@ public static class SetIntegerInput implements Serializable {
         private Boolean negate;
         private boolean negateSeen = false;
 
+        private String apiClient;
+        private boolean apiClientSeen = false;
+
         public SetIntegerInput(String key, int value) {
             this.key = key;
 
@@ -1128,6 +1131,17 @@ public SetIntegerInput setNegate(@Nullable Boolean negate) {
             return this;
         }
 
+        @Nullable
+        public String getApiClient() {
+            return apiClient;
+        }
+
+        public SetIntegerInput setApiClient(@Nullable String apiClient) {
+            this.apiClient = apiClient;
+            this.apiClientSeen = true;
+            return this;
+        }
+
         public void appendTo(StringBuilder _queryBuilder) {
             String separator = "";
             _queryBuilder.append('{');
@@ -1164,6 +1178,17 @@ public void appendTo(StringBuilder _queryBuilder) {
                 }
             }
 
+            if (this.apiClientSeen) {
+                _queryBuilder.append(separator);
+                separator = ",";
+                _queryBuilder.append("api_client:");
+                if (apiClient != null) {
+                    Query.appendQuotedString(_queryBuilder, apiClient.toString());
+                } else {
+                    _queryBuilder.append("null");
+                }
+            }
+
             _queryBuilder.append('}');
         }
     }