Skip to content

Commit 56bfe82

Browse files
author
0xSachinK
committed
Fix division by zero error
1 parent 90b0276 commit 56bfe82

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

contracts/protocol/modules/v2/PerpV2BasisTradingModule.sol

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -425,11 +425,16 @@ contract PerpV2BasisTradingModule is PerpV2LeverageModuleV2 {
425425
override(PerpV2LeverageModuleV2)
426426
returns (int256[] memory, int256[] memory _)
427427
{
428-
uint256 updatedSettledFunding = _getUpdatedSettledFunding(_setToken);
428+
int256 newExternalPositionUnitNetFees = 0;
429429

430-
int256 newExternalPositionUnit = _executePositionTrades(_setToken, _setTokenQuantity, false, true);
430+
if (positions[_setToken].length > 0) {
431431

432-
int256 newExternalPositionUnitNetFees = _calculateNetFeesPositionUnit(_setToken, newExternalPositionUnit, updatedSettledFunding);
432+
uint256 updatedSettledFunding = _getUpdatedSettledFunding(_setToken);
433+
434+
int256 newExternalPositionUnit = _executePositionTrades(_setToken, _setTokenQuantity, false, true);
435+
436+
newExternalPositionUnitNetFees = _calculateNetFeesPositionUnit(_setToken, newExternalPositionUnit, updatedSettledFunding);
437+
}
433438

434439
return _formatAdjustments(_setToken, newExternalPositionUnitNetFees);
435440
}

0 commit comments

Comments
 (0)