Design improvement: Return early if no funding will be withdrawn

0xSachinK · 0xSachinK · commit 2d9afda4279f · 2022-03-25T12:52:56.000+05:30
diff --git a/contracts/protocol/modules/v2/PerpV2BasisTradingModule.sol b/contracts/protocol/modules/v2/PerpV2BasisTradingModule.sol
@@ -212,6 +212,8 @@ contract PerpV2BasisTradingModule is PerpV2LeverageModuleV2 {
         nonReentrant
         onlyManagerAndValidSet(_setToken)
     {
+        if (_notionalFunding == 0) return;
+
         uint256 newSettledFunding = _updateSettledFunding(_setToken);
 
         uint256 settledFundingInCollateralDecimals = newSettledFunding.fromPreciseUnitToDecimals(collateralDecimals);

Original file line number	Diff line number	Diff line change
`@@ -212,6 +212,8 @@ contract PerpV2BasisTradingModule is PerpV2LeverageModuleV2 {`
`212`	`212`	`nonReentrant`
`213`	`213`	`onlyManagerAndValidSet(_setToken)`
`214`	`214`	`{`
	`215`	`+ if (_notionalFunding == 0) return;`
	`216`	`+`
`215`	`217`	`uint256 newSettledFunding = _updateSettledFunding(_setToken);`
`216`	`218`
`217`	`219`	`uint256 settledFundingInCollateralDecimals = newSettledFunding.fromPreciseUnitToDecimals(collateralDecimals);`