Skip to content

Conversation

@alaahong
Copy link
Member

@alaahong alaahong commented Jun 30, 2024

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

update feature/service

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Documentation


Description

  • Translated the Driver Service documentation page from English to Chinese.
  • Updated the title, section headers, and content to reflect accurate Chinese terminology.
  • Ensured that all technical terms, code examples, and references are correctly translated and remain accurate.

Changes walkthrough 📝

Relevant files
Documentation
service.zh-cn.md
Translate Driver Service Documentation to Chinese               

website_and_docs/content/documentation/webdriver/drivers/service.zh-cn.md

  • Translated the title and content from English to Chinese.
  • Updated terminology and explanations to be consistent with the Chinese
    language.
  • Ensured technical terms and code examples remain accurate.
  • +20/-16 

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @netlify
    Copy link

    netlify bot commented Jun 30, 2024

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 686ba7e

    @qodo-merge-pro qodo-merge-pro bot added the documentation Improvements or additions to documentation label Jun 30, 2024
    @qodo-merge-pro
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review [1-5] 2
    🧪 Relevant tests No
    🔒 Security concerns No
    ⚡ Key issues to review None

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jun 30, 2024

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    ✅ Add an example to clarify how to specify the driver port
    Suggestion Impact:The suggestion led to a modification in the documentation to clarify how to specify the driver port, although the exact example code was not included.

    code diff:

     如果希望驱动程序在特定端口上运行, 
    -可以按如下方式指定:
    +您可以在启动时指定端口号, 如下所示:

    Consider adding a brief explanation or example of how to specify the driver port, similar
    to the original English version. This will help users understand the implementation
    details more clearly.

    website_and_docs/content/documentation/webdriver/drivers/service.zh-cn.md [74-75]

    -如果希望驱动程序在特定端口上运行, 
    -可以按如下方式指定:
    +如果希望驱动程序在特定端口上运行, 您可以在启动时指定端口号, 如下所示:
    +```java
    +WebDriver driver = new ChromeDriver(new ChromeOptions().setPort(4567));
    +```
     
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: The suggestion provides a clear example of how to specify the driver port, which enhances the user's understanding and mirrors the detail provided in the original English version.

    9
    Add an example to clarify how to set up logging

    Add a brief explanation or example for setting up logging, similar to the original English
    version, to enhance clarity for users.

    website_and_docs/content/documentation/webdriver/drivers/service.zh-cn.md [103-105]

    -日志记录功能因浏览器而异.
    -大多数浏览器都允许您指定日志的位置和级别.
    +日志记录功能因浏览器而异. 例如, 在 Chrome 中, 您可以通过以下方式设置日志级别和位置:
    +```java
    +ChromeOptions options = new ChromeOptions();
    +options.setCapability("goog:loggingPrefs", new HashMap<string, object="">() {{
    +    put("browser", "ALL");
    +}});
    +WebDriver driver = new ChromeDriver(options);
    +```
     请查看相应的浏览器页面:
     
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: The suggestion includes a practical example for setting up logging, which improves clarity and usability for users, similar to the original English documentation.

    9
    Maintainability
    Add the English term for "Default Service instance" in the section header for consistency

    Ensure consistency in the translation of section headers by adding the translated term for
    "Default Service instance" to maintain uniformity with other headers.

    website_and_docs/content/documentation/webdriver/drivers/service.zh-cn.md [15]

    -## 默认服务实例
    +## 默认服务实例 (Default Service instance)
     
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: Adding the English term for "Default Service instance" improves consistency and helps bilingual users, though it is a minor enhancement.

    7

    @alaahong alaahong merged commit bf642bd into SeleniumHQ:trunk Jun 30, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    documentation Improvements or additions to documentation Review effort [1-5]: 2

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    1 participant