Skip to content

Commit 68420be

Browse files
committed
Fixes and completes install_addon() tests on firefox (#1609)
test_install_addon_directory() was being called with an xpi file fixture instead of a directory fixture. I fixed this by making a new fixture for test_install_addon_directory() that points to the test extension directory. See details here below. I also added an additional test and fixture so that the tests take into account whether a path to an extension directory ends with a trailing slash. See details here below. This required renaming the existing addon_path fixture to avoid confusion among the three related fixtures: - addon_path_xpi renamed fixture gives a path to the xpi file (was addon_path) updated test_install_add() and test_unistall_addon() - addon_path_dir new fixture that gives a path to the extension directory, ending without a '/' updated test_install_unsigned_addon_directory() to use it - addon_path_dir_slash (new fixture, and test) new fixture that gives a path to the extension directory, ending with a '/' added new test: test_install_unsigned_addon_directory_slash() Note that I don't have the appropriate environment to run these tests before pushing them. [deploy site] 14a74c9
1 parent 20f2e05 commit 68420be

File tree

26 files changed

+166
-166
lines changed

26 files changed

+166
-166
lines changed

documentation/_print/index.html

Lines changed: 13 additions & 13 deletions
Large diffs are not rendered by default.

documentation/about/_print/index.html

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -59,17 +59,17 @@
5959
<label><a href=https://github.com/lukeis>@lukeis</a></label>
6060
<span class=contributions>599 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/665846?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
6161
<label><a href=https://github.com/p0deje>@p0deje</a></label>
62-
<span class=contributions>549 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/1072163?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
62+
<span class=contributions>559 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/1072163?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
6363
<label><a href=https://github.com/eranmes>@eranmes</a></label>
6464
<span class=contributions>473 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/10705590?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
6565
<label><a href=https://github.com/pujagani>@pujagani</a></label>
66-
<span class=contributions>440 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/610?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
66+
<span class=contributions>449 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/610?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
6767
<label><a href=https://github.com/mdub>@mdub</a></label>
6868
<span class=contributions>326 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/399120?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
6969
<label><a href=https://github.com/andreastt>@andreastt</a></label>
7070
<span class=contributions>289 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/5413013?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
7171
<label><a href=https://github.com/bonigarcia>@bonigarcia</a></label>
72-
<span class=contributions>226 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/67744?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
72+
<span class=contributions>234 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/67744?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
7373
<label><a href=https://github.com/krosenvold>@krosenvold</a></label>
7474
<span class=contributions>225 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/8536?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
7575
<label><a href=https://github.com/hugs>@hugs</a></label>
@@ -101,11 +101,11 @@
101101
<label><a href=https://github.com/aslakhellesoy>@aslakhellesoy</a></label>
102102
<span class=contributions>94 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/22616990?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
103103
<label><a href=https://github.com/nvborisenko>@nvborisenko</a></label>
104-
<span class=contributions>92 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/3902563?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
104+
<span class=contributions>93 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/3902563?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
105105
<label><a href=https://github.com/alex-savchuk>@alex-savchuk</a></label>
106106
<span class=contributions>90 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/in/29110?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
107107
<label><a href=https://github.com/apps/dependabot>@dependabot[bot]</a></label>
108-
<span class=contributions>77 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/695746?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
108+
<span class=contributions>79 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/695746?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
109109
<label><a href=https://github.com/andrashatvani>@andrashatvani</a></label>
110110
<span class=contributions>66 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/1015125?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
111111
<label><a href=https://github.com/ajayk>@ajayk</a></label>
@@ -525,7 +525,7 @@
525525
<label><a href=https://github.com/diemol>@diemol</a></label>
526526
<span class=contributions>711 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/12621691?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
527527
<label><a href=https://github.com/harsha509>@harsha509</a></label>
528-
<span class=contributions>651 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/3331063?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
528+
<span class=contributions>652 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/3331063?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
529529
<label><a href=https://github.com/selenium-ci>@selenium-ci</a></label>
530530
<span class=contributions>323 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/777185?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
531531
<label><a href=https://github.com/titusfortner>@titusfortner</a></label>
@@ -711,16 +711,16 @@
711711
<label><a href=https://github.com/MohabMohie>@MohabMohie</a></label>
712712
<span class=contributions>2 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/74588305?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
713713
<label><a href=https://github.com/mmonfared>@mmonfared</a></label>
714-
<span class=contributions>2 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/6885369?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
715-
<label><a href=https://github.com/naeemakram>@naeemakram</a></label>
716714
<span class=contributions>2 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/27953094?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
717715
<label><a href=https://github.com/rahuljhakant>@rahuljhakant</a></label>
716+
<span class=contributions>2 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/6885369?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
717+
<label><a href=https://github.com/naeemakram>@naeemakram</a></label>
718718
<span class=contributions>2 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/7305503?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
719719
<label><a href=https://github.com/natanportilho>@natanportilho</a></label>
720-
<span class=contributions>2 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/12666836?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
720+
<span class=contributions>2 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/5081226?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
721+
<label><a href=https://github.com/valfirst>@valfirst</a></label>
722+
<span class=contributions>1 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/12666836?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
721723
<label><a href=https://github.com/TS000>@TS000</a></label>
722-
<span class=contributions>1 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/54274976?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
723-
<label><a href=https://github.com/TurboSlayer>@TurboSlayer</a></label>
724724
<span class=contributions>1 commits</span></div></div><h4 id=previous-selenium-websitegithubcomseleniumhqwwwseleniumhqorg><a href=//github.com/SeleniumHQ/www.seleniumhq.org/>Previous Selenium Website</a></h4><style type=text/css>.ghContributors{display:flex;flex-flow:wrap;align-content:flex-start}.ghContributors>div{width:50%;display:inline-flex;margin-bottom:5px}.ghContributors>div label{padding-left:4px}.ghContributors>div span{font-size:x-small;padding-left:4px}</style><div class=ghContributors><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/926454?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>
725725
<label><a href=https://github.com/lukeis>@lukeis</a></label>
726726
<span class=contributions>417 commits</span></div><div style=padding:10px><img src="https://avatars.githubusercontent.com/u/28229?v=4" class=inline width=100 height=100 style=height:100px;height:100px;margin-bottom:.25em;vertical-align:middle>

0 commit comments

Comments
 (0)