From b1c91cc10d4408d020f88193cd9f0890a3c0d823 Mon Sep 17 00:00:00 2001 From: fazledyn-or Date: Fri, 13 Oct 2023 17:45:50 +0600 Subject: [PATCH 1/3] Replaced `NotImplementedError` with `NotImplemented` --- lib/iris/coords.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/iris/coords.py b/lib/iris/coords.py index 3ff9bc8e5e..d5ee2667d8 100644 --- a/lib/iris/coords.py +++ b/lib/iris/coords.py @@ -3119,7 +3119,7 @@ def __str__(self): def __add__(self, other): # Disable the default tuple behaviour of tuple concatenation - raise NotImplementedError() + return NotImplemented def xml_element(self, doc): """ From 561526b80922cba4b2c93188676dc09f198d03ab Mon Sep 17 00:00:00 2001 From: fazledyn-or Date: Tue, 17 Oct 2023 17:07:23 +0600 Subject: [PATCH 2/3] Added contribution to `latest.rst` --- docs/src/whatsnew/latest.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/src/whatsnew/latest.rst b/docs/src/whatsnew/latest.rst index c5cd961679..8d0190dce2 100644 --- a/docs/src/whatsnew/latest.rst +++ b/docs/src/whatsnew/latest.rst @@ -102,6 +102,9 @@ This document explains the changes made to Iris for this release #. `@trexfeathers`_ adapted benchmarking to work with ASV ``>=v0.6`` by no longer using the ``--strict`` argument. (:pull:`5496`) +#. `@fazledyn-or`_ replaced ``NotImplementedError`` with ``NotImplemented`` as + a proper method call. (:pull:`5544`) + .. comment Whatsnew author names (@github name) in alphabetical order. Note that, From e998948b48b02c590c787e7803d9178ad4b716a3 Mon Sep 17 00:00:00 2001 From: fazledyn-or Date: Tue, 17 Oct 2023 17:46:25 +0600 Subject: [PATCH 3/3] Added github handle in the link section --- docs/src/whatsnew/latest.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/src/whatsnew/latest.rst b/docs/src/whatsnew/latest.rst index 8d0190dce2..9564863d1b 100644 --- a/docs/src/whatsnew/latest.rst +++ b/docs/src/whatsnew/latest.rst @@ -112,6 +112,7 @@ This document explains the changes made to Iris for this release .. _@scottrobinson02: https://github.com/scottrobinson02 .. _@acchamber: https://github.com/acchamber +.. _@fazledyn-or: https://github.com/fazledyn-or .. comment