From e945e2044f9155bf7e8c885c9b7155f5208a7364 Mon Sep 17 00:00:00 2001 From: Patrick Peglar Date: Mon, 5 Jul 2021 12:49:53 +0100 Subject: [PATCH 1/4] Update __init__.py --- lib/iris/experimental/ugrid/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/iris/experimental/ugrid/__init__.py b/lib/iris/experimental/ugrid/__init__.py index 8eefedb6ea..035fe576e0 100644 --- a/lib/iris/experimental/ugrid/__init__.py +++ b/lib/iris/experimental/ugrid/__init__.py @@ -3643,7 +3643,7 @@ def _build_connectivity(connectivity_var, file_path, location_dims): indices_data = netcdf._get_cf_var_data(connectivity_var, file_path) cf_role = connectivity_var.cf_role - start_index = connectivity_var.start_index + start_index = getattr(connectivity_var, 'start_index', None) dim_names = connectivity_var.dimensions # Connectivity arrays must have two dimensions. From d3c4701207b6a64eaaf9598eb8e536ebcfb1c525 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 5 Jul 2021 11:52:28 +0000 Subject: [PATCH 2/4] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- lib/iris/experimental/ugrid/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/iris/experimental/ugrid/__init__.py b/lib/iris/experimental/ugrid/__init__.py index 035fe576e0..b3f85d830e 100644 --- a/lib/iris/experimental/ugrid/__init__.py +++ b/lib/iris/experimental/ugrid/__init__.py @@ -3643,7 +3643,7 @@ def _build_connectivity(connectivity_var, file_path, location_dims): indices_data = netcdf._get_cf_var_data(connectivity_var, file_path) cf_role = connectivity_var.cf_role - start_index = getattr(connectivity_var, 'start_index', None) + start_index = getattr(connectivity_var, "start_index", None) dim_names = connectivity_var.dimensions # Connectivity arrays must have two dimensions. From 5b56b33b3a35c7252e306caf75212cc987f15847 Mon Sep 17 00:00:00 2001 From: Patrick Peglar Date: Mon, 5 Jul 2021 17:56:03 +0100 Subject: [PATCH 3/4] Fix default start_index --- lib/iris/experimental/ugrid/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/iris/experimental/ugrid/__init__.py b/lib/iris/experimental/ugrid/__init__.py index b3f85d830e..138e532e30 100644 --- a/lib/iris/experimental/ugrid/__init__.py +++ b/lib/iris/experimental/ugrid/__init__.py @@ -3643,7 +3643,7 @@ def _build_connectivity(connectivity_var, file_path, location_dims): indices_data = netcdf._get_cf_var_data(connectivity_var, file_path) cf_role = connectivity_var.cf_role - start_index = getattr(connectivity_var, "start_index", None) + start_index = getattr(connectivity_var, "start_index", 0) dim_names = connectivity_var.dimensions # Connectivity arrays must have two dimensions. From 8dfec013573a2e4d7a539dd68d8b8984bf074cc9 Mon Sep 17 00:00:00 2001 From: Martin Yeo Date: Tue, 4 May 2021 15:46:44 +0100 Subject: [PATCH 4/4] Corrected plot_anomaly_log_colouring for new Matplotlib linscale rules: Duplicates #4115. --- docs/gallery_code/general/plot_anomaly_log_colouring.py | 4 ++-- lib/iris/tests/results/imagerepo.json | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/docs/gallery_code/general/plot_anomaly_log_colouring.py b/docs/gallery_code/general/plot_anomaly_log_colouring.py index 5bde12ca39..7a6405b4b0 100644 --- a/docs/gallery_code/general/plot_anomaly_log_colouring.py +++ b/docs/gallery_code/general/plot_anomaly_log_colouring.py @@ -68,13 +68,13 @@ def main(): # Create a 'logarithmic' data normalization. anom_norm = mcols.SymLogNorm( linthresh=minimum_log_level, - linscale=1, + linscale=0.01, vmin=-maximum_scale_level, vmax=maximum_scale_level, ) # Setting "linthresh=minimum_log_level" makes its non-logarithmic # data range equal to our 'zero band'. - # Setting "linscale=1" maps the whole zero band to the middle colour value + # Setting "linscale=0.01" maps the whole zero band to the middle colour value # (i.e., 0.5), which is the neutral point of a "diverging" style colormap. # Create an Axes, specifying the map projection. diff --git a/lib/iris/tests/results/imagerepo.json b/lib/iris/tests/results/imagerepo.json index d73c8492e5..183ac6097f 100644 --- a/lib/iris/tests/results/imagerepo.json +++ b/lib/iris/tests/results/imagerepo.json @@ -23,8 +23,7 @@ "gallery_tests.test_plot_anomaly_log_colouring.TestAnomalyLogColouring.test_plot_anomaly_log_colouring.0": [ "https://scitools.github.io/test-iris-imagehash/images/v4/ec4464e185a39f93931e9b1e91696d2949dde6e63e26a47a5ad391938d9a5a0c.png", "https://scitools.github.io/test-iris-imagehash/images/v4/ecc164e78e979b19b3789b0885a564a56cc2c65e3ec69469db1bdb9a853c1e24.png", - "https://scitools.github.io/test-iris-imagehash/images/v4/ece164e68e979b19b3781b0885a564a56ccac65e3ec69469db1bdb9a853c1e24.png", - "https://scitools.github.io/test-iris-imagehash/images/v4/ece164e796979a1b39781b2881a564a56ccac6da3e87947bcb1bdb9a843c1e24.png" + "https://scitools.github.io/test-iris-imagehash/images/v4/ece164e68e979b19b3781b0885a564a56ccac65e3ec69469db1bdb9a853c1e24.png" ], "gallery_tests.test_plot_atlantic_profiles.TestAtlanticProfiles.test_plot_atlantic_profiles.0": [ "https://scitools.github.io/test-iris-imagehash/images/v4/9f8260536bd28e1320739437b5f437b0a51d66f4cc5d08fcd00fdb1c93fcb21c.png", @@ -1048,4 +1047,4 @@ "https://scitools.github.io/test-iris-imagehash/images/v4/82fe81987fdf77ffe0002addd4002805dd28df67d9a9d4625bfddc209841de20.png", "https://scitools.github.io/test-iris-imagehash/images/v4/82fa80997f547799a0037a00d52f0956ddaf9f7e98a1816e09f5d8260bfffe00.png" ] -} \ No newline at end of file +}