Skip to content

[LAB1] a121100 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2024
Merged

[LAB1] a121100 #42

merged 1 commit into from
Mar 7, 2024

Conversation

@Sharkkcode
Copy link

@Sharkkcode Sharkkcode commented Feb 29, 2024 •
edited
Loading

Description

Add test cases in lab1/main_test.js and validated with lab1/validate.sh .

  • A clear title (name your pr "[LAB{lab_number}] {your_student_id}")
  • A meaningful message for PR, as well as its commits
  • From your specific branch (not main or other's branch) merging to your branch
  • Excluding any irrelevant files, such as binaries, text files, or dot files
  • Passing tests/CI

@TaiYou-TW TaiYou-TW added the lab1 label Feb 29, 2024
@Sharkkcode Sharkkcode marked this pull request as draft February 29, 2024 15:20
@Sharkkcode Sharkkcode marked this pull request as ready for review February 29, 2024 15:20
@Sharkkcode Sharkkcode marked this pull request as draft February 29, 2024 15:20
@Sharkkcode Sharkkcode marked this pull request as ready for review February 29, 2024 15:22
@Sharkkcode Sharkkcode changed the title [Lab1] a121100 [LAB1] a121100 Feb 29, 2024
@TaiYou-TW TaiYou-TW merged commit 01dddfc into SQLab:a121100 Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

lab1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sharkkcode @TaiYou-TW