Skip to content

Conversation

@EusdenLin
Copy link

@EusdenLin EusdenLin commented Feb 29, 2024

Description

Add test cases in main_test.js, validated with validate.sh.

  • A clear title (name your pr "[LAB{lab_number}] {your_student_id}")
  • A meaningful message for PR, as well as its commits
  • From your specific branch (not main or other's branch) merging to your branch
  • Excluding any irrelevant files, such as binaries, text files, or dot files
  • Passing tests/CI

@TaiYou-TW TaiYou-TW closed this Feb 29, 2024
@TaiYou-TW TaiYou-TW reopened this Feb 29, 2024
@TaiYou-TW TaiYou-TW added the lab1 label Feb 29, 2024
@TaiYou-TW TaiYou-TW merged commit dec05be into SQLab:312551098 Mar 7, 2024
@TaiYou-TW
Copy link
Contributor

Remember to follow PR title's rule next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants