Skip to content

Commit e9fb157

Browse files
committed
add comment
1 parent defb9bb commit e9fb157

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

pkg/reconciler/reconciler.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -748,6 +748,10 @@ func (r *Reconciler) Apply(ctx context.Context, inventory *[]*InventoryItem, obj
748748
if existingObject.GetDeletionTimestamp().IsZero() && existingStatus == status.CurrentStatus {
749749
item.Phase = PhaseReady
750750
} else {
751+
// TODO: is it wise to not change item.Phase here?
752+
// Not changing it means that a dependent's phase stays at the last known value (which might even be Ready);
753+
// which means in particular that a dependent that has reached a Ready phase will not change its phase
754+
// if the dependent object starts to flicker; perhaps this is a wanted behaviour.
751755
numUnready++
752756
}
753757
item.Status = existingStatus

0 commit comments

Comments
 (0)