Revert "fix lookup regression again (microsoft#26762)"

This reverts commit 038f665.

Author: RyanCavanaugh

src/compiler/checker.ts

@@ -1213,7 +1213,7 @@ namespace ts {
                             }
                             if (meaning & SymbolFlags.Value && result.flags & SymbolFlags.Variable) {
                                 // expression inside parameter will lookup as normal variable scope when targeting es2015+
-                                if (compilerOptions.target && compilerOptions.target >= ScriptTarget.ES2015 && isParameter(lastLocation) && !isParameterPropertyDeclaration(lastLocation) && result.valueDeclaration.pos > lastLocation.end) {
+                                if (compilerOptions.target && compilerOptions.target >= ScriptTarget.ES2015 && isParameter(lastLocation) && !isParameterPropertyDeclaration(lastLocation) && result.valueDeclaration !== lastLocation) {
                                     useResult = false;
                                 }
                                 else if (result.flags & SymbolFlags.FunctionScopedVariable) {

tests/baselines/reference/parameterInitializersForwardReferencing1.errors.txt

@@ -55,6 +55,4 @@ tests/cases/conformance/functions/parameterInitializersForwardReferencing1.ts(29
     class Foo {
         constructor(public x = 12, public y = x) {}
     }
-    
-    function f8(foo1: string, bar = foo1) { }
 

tests/baselines/reference/parameterInitializersForwardReferencing1.js

@@ -34,8 +34,6 @@ function f7({[foo]: bar}: any[]) {
 class Foo {
     constructor(public x = 12, public y = x) {}
 }
-
-function f8(foo1: string, bar = foo1) { }
 
 
 //// [parameterInitializersForwardReferencing1.js]
@@ -83,6 +81,3 @@ var Foo = /** @class */ (function () {
     }
     return Foo;
 }());
-function f8(foo1, bar) {
-    if (bar === void 0) { bar = foo1; }
-}

tests/baselines/reference/parameterInitializersForwardReferencing1.symbols

@@ -84,9 +84,3 @@ class Foo {
 >x : Symbol(x, Decl(parameterInitializersForwardReferencing1.ts, 33, 16))
 }
 
-function f8(foo1: string, bar = foo1) { }
->f8 : Symbol(f8, Decl(parameterInitializersForwardReferencing1.ts, 34, 1))
->foo1 : Symbol(foo1, Decl(parameterInitializersForwardReferencing1.ts, 36, 12))
->bar : Symbol(bar, Decl(parameterInitializersForwardReferencing1.ts, 36, 25))
->foo1 : Symbol(foo1, Decl(parameterInitializersForwardReferencing1.ts, 36, 12))
-

tests/baselines/reference/parameterInitializersForwardReferencing1.types

@@ -92,9 +92,3 @@ class Foo {
 >x : number
 }
 
-function f8(foo1: string, bar = foo1) { }
->f8 : (foo1: string, bar?: string) => void
->foo1 : string
->bar : string
->foo1 : string
-

tests/baselines/reference/parameterInitializersForwardReferencing1_es6.errors.txt

@@ -42,6 +42,4 @@ tests/cases/conformance/functions/parameterInitializersForwardReferencing1_es6.t
     class Foo {
         constructor(public x = 12, public y = x) {}
     }
-    
-    function f8(foo1: string, bar = foo1) { }
 

tests/baselines/reference/parameterInitializersForwardReferencing1_es6.js

@@ -34,8 +34,6 @@ function f7({[foo]: bar}: any[]) {
 class Foo {
     constructor(public x = 12, public y = x) {}
 }
-
-function f8(foo1: string, bar = foo1) { }
 
 
 //// [parameterInitializersForwardReferencing1_es6.js]
@@ -69,4 +67,3 @@ class Foo {
         this.y = y;
     }
 }
-function f8(foo1, bar = foo1) { }

tests/baselines/reference/parameterInitializersForwardReferencing1_es6.symbols

@@ -42,7 +42,7 @@ function f4 (foo, bar = foo) {
 >f4 : Symbol(f4, Decl(parameterInitializersForwardReferencing1_es6.ts, 14, 1))
 >foo : Symbol(foo, Decl(parameterInitializersForwardReferencing1_es6.ts, 16, 13))
 >bar : Symbol(bar, Decl(parameterInitializersForwardReferencing1_es6.ts, 16, 17))
->foo : Symbol(foo, Decl(parameterInitializersForwardReferencing1_es6.ts, 16, 13))
+>foo : Symbol(foo, Decl(parameterInitializersForwardReferencing1_es6.ts, 0, 3))
 
     return bar
 >bar : Symbol(bar, Decl(parameterInitializersForwardReferencing1_es6.ts, 16, 17))
@@ -84,9 +84,3 @@ class Foo {
 >x : Symbol(x, Decl(parameterInitializersForwardReferencing1_es6.ts, 33, 16))
 }
 
-function f8(foo1: string, bar = foo1) { }
->f8 : Symbol(f8, Decl(parameterInitializersForwardReferencing1_es6.ts, 34, 1))
->foo1 : Symbol(foo1, Decl(parameterInitializersForwardReferencing1_es6.ts, 36, 12))
->bar : Symbol(bar, Decl(parameterInitializersForwardReferencing1_es6.ts, 36, 25))
->foo1 : Symbol(foo1, Decl(parameterInitializersForwardReferencing1_es6.ts, 36, 12))
-

tests/baselines/reference/parameterInitializersForwardReferencing1_es6.types

@@ -45,13 +45,13 @@ function f3 (bar = foo, foo = 2) { // correct compiler error, error at runtime
 }
 
 function f4 (foo, bar = foo) {
->f4 : (foo: any, bar?: any) => any
->foo : any
->bar : any
+>f4 : (foo: any, bar?: string) => string
 >foo : any
+>bar : string
+>foo : string
 
     return bar
->bar : any
+>bar : string
 }
 
 function f5 (a = a) {
@@ -92,9 +92,3 @@ class Foo {
 >x : number
 }
 
-function f8(foo1: string, bar = foo1) { }
->f8 : (foo1: string, bar?: string) => void
->foo1 : string
->bar : string
->foo1 : string
-

tests/cases/conformance/functions/parameterInitializersForwardReferencing1.ts

@@ -33,5 +33,3 @@ function f7({[foo]: bar}: any[]) {
 class Foo {
     constructor(public x = 12, public y = x) {}
 }
-
-function f8(foo1: string, bar = foo1) { }