From 26db2da3eb84856d997e05caf9904a6b56eac1e8 Mon Sep 17 00:00:00 2001 From: Simon Maertens Date: Wed, 29 Nov 2023 14:30:30 +0000 Subject: [PATCH 1/4] Fixed Fortran compiler flags check for nagfor compiler and usage in CBLAS target --- CBLAS/CMakeLists.txt | 4 ++++ CMAKE/CheckLAPACKCompilerFlags.cmake | 1 + 2 files changed, 5 insertions(+) diff --git a/CBLAS/CMakeLists.txt b/CBLAS/CMakeLists.txt index c276f7da3d..b01d795af9 100644 --- a/CBLAS/CMakeLists.txt +++ b/CBLAS/CMakeLists.txt @@ -14,6 +14,10 @@ if(CMAKE_Fortran_COMPILER) FortranCInterface_HEADER(${LAPACK_BINARY_DIR}/include/cblas_mangling.h MACRO_NAMESPACE "F77_" SYMBOL_NAMESPACE "F77_") + + # Check for any necessary platform specific compiler flags + include(CheckLAPACKCompilerFlags) + CheckLAPACKCompilerFlags() endif() if(NOT FortranCInterface_GLOBAL_FOUND OR NOT FortranCInterface_MODULE_FOUND) message(WARNING "Reverting to pre-defined include/cblas_mangling.h") diff --git a/CMAKE/CheckLAPACKCompilerFlags.cmake b/CMAKE/CheckLAPACKCompilerFlags.cmake index ecb5009ae5..653b817583 100644 --- a/CMAKE/CheckLAPACKCompilerFlags.cmake +++ b/CMAKE/CheckLAPACKCompilerFlags.cmake @@ -177,6 +177,7 @@ elseif( CMAKE_Fortran_COMPILER_ID STREQUAL "NAG" ) endif() # Suppress compiler banner and summary + include(CheckFortranCompilerFlag) check_fortran_compiler_flag("-quiet" _quiet) if( _quiet AND NOT ("${CMAKE_Fortran_FLAGS}" MATCHES "[-/]quiet") ) set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -quiet") From 8c54a57d66e7fa8839eaabd81b0236203ead22e7 Mon Sep 17 00:00:00 2001 From: Simon Maertens Date: Wed, 29 Nov 2023 14:31:16 +0000 Subject: [PATCH 2/4] Replaced non-standard `IMAG` function with its standard counterpart `AIMAG. --- SRC/claqp2rk.f | 6 +++--- SRC/claqp3rk.f | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/SRC/claqp2rk.f b/SRC/claqp2rk.f index 6b1db085aa..0501c50bb4 100755 --- a/SRC/claqp2rk.f +++ b/SRC/claqp2rk.f @@ -378,7 +378,7 @@ SUBROUTINE CLAQP2RK( M, N, NRHS, IOFFSET, KMAX, ABSTOL, RELTOL, EXTERNAL CLARF, CLARFG, CSWAP * .. * .. Intrinsic Functions .. - INTRINSIC ABS, REAL, CONJG, IMAG, MAX, MIN, SQRT + INTRINSIC ABS, REAL, CONJG, AIMAG, MAX, MIN, SQRT * .. * .. External Functions .. LOGICAL SISNAN @@ -599,8 +599,8 @@ SUBROUTINE CLAQP2RK( M, N, NRHS, IOFFSET, KMAX, ABSTOL, RELTOL, * IF( SISNAN( REAL( TAU(KK) ) ) ) THEN TAUNAN = REAL( TAU(KK) ) - ELSE IF( SISNAN( IMAG( TAU(KK) ) ) ) THEN - TAUNAN = IMAG( TAU(KK) ) + ELSE IF( SISNAN( AIMAG( TAU(KK) ) ) ) THEN + TAUNAN = AIMAG( TAU(KK) ) ELSE TAUNAN = ZERO END IF diff --git a/SRC/claqp3rk.f b/SRC/claqp3rk.f index 3703bcbd65..8fe5a220ff 100755 --- a/SRC/claqp3rk.f +++ b/SRC/claqp3rk.f @@ -431,7 +431,7 @@ SUBROUTINE CLAQP3RK( M, N, NRHS, IOFFSET, NB, ABSTOL, EXTERNAL CGEMM, CGEMV, CLARFG, CSWAP * .. * .. Intrinsic Functions .. - INTRINSIC ABS, REAL, CONJG, IMAG, MAX, MIN, SQRT + INTRINSIC ABS, REAL, CONJG, AIMAG, MAX, MIN, SQRT * .. * .. External Functions .. LOGICAL SISNAN @@ -739,8 +739,8 @@ SUBROUTINE CLAQP3RK( M, N, NRHS, IOFFSET, NB, ABSTOL, * IF( SISNAN( REAL( TAU(K) ) ) ) THEN TAUNAN = REAL( TAU(K) ) - ELSE IF( SISNAN( IMAG( TAU(K) ) ) ) THEN - TAUNAN = IMAG( TAU(K) ) + ELSE IF( SISNAN( AIMAG( TAU(K) ) ) ) THEN + TAUNAN = AIMAG( TAU(K) ) ELSE TAUNAN = ZERO END IF From c69a96ea9ee407b1d7284303e9ea89ba23f88424 Mon Sep 17 00:00:00 2001 From: Simon Maertens Date: Wed, 29 Nov 2023 14:33:00 +0000 Subject: [PATCH 3/4] Added missing comma in `FORMAT` expression --- TESTING/LIN/alahd.f | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/TESTING/LIN/alahd.f b/TESTING/LIN/alahd.f index 8f966c5841..a566d52716 100755 --- a/TESTING/LIN/alahd.f +++ b/TESTING/LIN/alahd.f @@ -954,7 +954,7 @@ SUBROUTINE ALAHD( IOUNIT, PATH ) $ 4X, '10. Random, Last columns are zero starting from', $ ' MINMN/2+1, CNDNUM = 2', / $ 4X, '11. Random, Half MINMN columns in the middle are', - $ ' zero starting from MINMN/2-(MINMN/2)/2+1,' + $ ' zero starting from MINMN/2-(MINMN/2)/2+1', $ ' CNDNUM = 2', / $ 4X, '12. Random, Odd columns are ZERO, CNDNUM = 2', / $ 4X, '13. Random, Even columns are ZERO, CNDNUM = 2', / From 2a0aea9c4c87a5f186bcaf19dd72a2b9223050cd Mon Sep 17 00:00:00 2001 From: Simon Maertens Date: Wed, 29 Nov 2023 14:34:19 +0000 Subject: [PATCH 4/4] Added missing comma in `FORMAT` expression --- TESTING/LIN/alahd.f | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/TESTING/LIN/alahd.f b/TESTING/LIN/alahd.f index a566d52716..c0334b5de9 100755 --- a/TESTING/LIN/alahd.f +++ b/TESTING/LIN/alahd.f @@ -954,7 +954,7 @@ SUBROUTINE ALAHD( IOUNIT, PATH ) $ 4X, '10. Random, Last columns are zero starting from', $ ' MINMN/2+1, CNDNUM = 2', / $ 4X, '11. Random, Half MINMN columns in the middle are', - $ ' zero starting from MINMN/2-(MINMN/2)/2+1', + $ ' zero starting from MINMN/2-(MINMN/2)/2+1,', $ ' CNDNUM = 2', / $ 4X, '12. Random, Odd columns are ZERO, CNDNUM = 2', / $ 4X, '13. Random, Even columns are ZERO, CNDNUM = 2', /