From aec6cb32817bd2acc71b66d67d036b454278dff7 Mon Sep 17 00:00:00 2001 From: scr2016 <1015908+scr2016@users.noreply.github.com> Date: Mon, 20 Nov 2023 22:58:28 -0800 Subject: [PATCH 1/3] Fixed an error in the description of complex routines, changed othogonal into unitary --- SRC/cgeqp3rk.f | 8 ++++---- SRC/claqp2rk.f | 2 +- SRC/claqp3rk.f | 2 +- SRC/zgeqp3rk.f | 8 ++++---- SRC/zlaqp2rk.f | 2 +- SRC/zlaqp3rk.f | 2 +- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/SRC/cgeqp3rk.f b/SRC/cgeqp3rk.f index 70789e64fb..59e26f8777 100755 --- a/SRC/cgeqp3rk.f +++ b/SRC/cgeqp3rk.f @@ -55,7 +55,7 @@ *> where: *> *> P(K) is an N-by-N permutation matrix; -*> Q(K) is an M-by-M orthogonal matrix; +*> Q(K) is an M-by-M unitary matrix; *> R(K)_approx = ( R11(K), R12(K) ) is a rank K approximation of the *> full rank factor R with K-by-K upper-triangular *> R11(K) and K-by-N rectangular R12(K). The diagonal @@ -124,14 +124,14 @@ *> d) RELMAXC2NRMK equals MAXC2NRMK divided by MAXC2NRM, the maximum *> column 2-norm of the original matrix A, which is equal *> to abs(R(1,1)), ( if K = min(M,N), RELMAXC2NRMK = 0.0 ); -*> e) Q(K)**H * B, the matrix B with the orthogonal +*> e) Q(K)**H * B, the matrix B with the unitary *> transformation Q(K)**H applied on the left. *> *> The N-by-N permutation matrix P(K) is stored in a compact form in *> the integer array JPIV. For 1 <= j <= N, column j *> of the matrix A was interchanged with column JPIV(j). *> -*> The M-by-M orthogonal matrix Q is represented as a product +*> The M-by-M unitary matrix Q is represented as a product *> of elementary Householder reflectors *> *> Q(K) = H(1) * H(2) * . . . * H(K), @@ -300,7 +300,7 @@ *> *> 1. The elements below the diagonal of the subarray *> A(1:M,1:K) together with TAU(1:K) represent the -*> orthogonal matrix Q(K) as a product of K Householder +*> unitary matrix Q(K) as a product of K Householder *> elementary reflectors. *> *> 2. The elements on and above the diagonal of diff --git a/SRC/claqp2rk.f b/SRC/claqp2rk.f index 073ad0f88d..7645e5a18b 100755 --- a/SRC/claqp2rk.f +++ b/SRC/claqp2rk.f @@ -178,7 +178,7 @@ *> On exit: *> 1. The elements in block A(IOFFSET+1:M,1:K) below *> the diagonal together with the array TAU represent -*> the orthogonal matrix Q(K) as a product of elementary +*> the unitary matrix Q(K) as a product of elementary *> reflectors. *> 2. The upper triangular block of the matrix A stored *> in A(IOFFSET+1:M,1:K) is the triangular factor obtained. diff --git a/SRC/claqp3rk.f b/SRC/claqp3rk.f index af5e856457..c85c2e1c2a 100755 --- a/SRC/claqp3rk.f +++ b/SRC/claqp3rk.f @@ -196,7 +196,7 @@ *> On exit: *> 1. The elements in block A(IOFFSET+1:M,1:KB) below *> the diagonal together with the array TAU represent -*> the orthogonal matrix Q(KB) as a product of elementary +*> the unitary matrix Q(KB) as a product of elementary *> reflectors. *> 2. The upper triangular block of the matrix A stored *> in A(IOFFSET+1:M,1:KB) is the triangular factor obtained. diff --git a/SRC/zgeqp3rk.f b/SRC/zgeqp3rk.f index f8ef986c70..305247be1b 100755 --- a/SRC/zgeqp3rk.f +++ b/SRC/zgeqp3rk.f @@ -55,7 +55,7 @@ *> where: *> *> P(K) is an N-by-N permutation matrix; -*> Q(K) is an M-by-M orthogonal matrix; +*> Q(K) is an M-by-M unitary matrix; *> R(K)_approx = ( R11(K), R12(K) ) is a rank K approximation of the *> full rank factor R with K-by-K upper-triangular *> R11(K) and K-by-N rectangular R12(K). The diagonal @@ -124,14 +124,14 @@ *> d) RELMAXC2NRMK equals MAXC2NRMK divided by MAXC2NRM, the maximum *> column 2-norm of the original matrix A, which is equal *> to abs(R(1,1)), ( if K = min(M,N), RELMAXC2NRMK = 0.0 ); -*> e) Q(K)**H * B, the matrix B with the orthogonal +*> e) Q(K)**H * B, the matrix B with the unitary *> transformation Q(K)**H applied on the left. *> *> The N-by-N permutation matrix P(K) is stored in a compact form in *> the integer array JPIV. For 1 <= j <= N, column j *> of the matrix A was interchanged with column JPIV(j). *> -*> The M-by-M orthogonal matrix Q is represented as a product +*> The M-by-M unitary matrix Q is represented as a product *> of elementary Householder reflectors *> *> Q(K) = H(1) * H(2) * . . . * H(K), @@ -300,7 +300,7 @@ *> *> 1. The elements below the diagonal of the subarray *> A(1:M,1:K) together with TAU(1:K) represent the -*> orthogonal matrix Q(K) as a product of K Householder +*> unitary matrix Q(K) as a product of K Householder *> elementary reflectors. *> *> 2. The elements on and above the diagonal of diff --git a/SRC/zlaqp2rk.f b/SRC/zlaqp2rk.f index f1e9f48993..f9f1c4c700 100755 --- a/SRC/zlaqp2rk.f +++ b/SRC/zlaqp2rk.f @@ -178,7 +178,7 @@ *> On exit: *> 1. The elements in block A(IOFFSET+1:M,1:K) below *> the diagonal together with the array TAU represent -*> the orthogonal matrix Q(K) as a product of elementary +*> the unitary matrix Q(K) as a product of elementary *> reflectors. *> 2. The upper triangular block of the matrix A stored *> in A(IOFFSET+1:M,1:K) is the triangular factor obtained. diff --git a/SRC/zlaqp3rk.f b/SRC/zlaqp3rk.f index 7a9fdfd95b..e5777633f2 100755 --- a/SRC/zlaqp3rk.f +++ b/SRC/zlaqp3rk.f @@ -196,7 +196,7 @@ *> On exit: *> 1. The elements in block A(IOFFSET+1:M,1:KB) below *> the diagonal together with the array TAU represent -*> the orthogonal matrix Q(KB) as a product of elementary +*> the unitary matrix Q(KB) as a product of elementary *> reflectors. *> 2. The upper triangular block of the matrix A stored *> in A(IOFFSET+1:M,1:KB) is the triangular factor obtained. From dcbd80331eda89d1a63b4aa83ca16e2714d362b9 Mon Sep 17 00:00:00 2001 From: scr2016 <1015908+scr2016@users.noreply.github.com> Date: Mon, 20 Nov 2023 23:07:59 -0800 Subject: [PATCH 2/3] updated descriptions for the truncated QR routines --- SRC/cgeqp3rk.f | 4 ++-- SRC/claqp2rk.f | 4 ++-- SRC/claqp3rk.f | 4 ++-- SRC/zgeqp3rk.f | 4 ++-- SRC/zlaqp2rk.f | 4 ++-- SRC/zlaqp3rk.f | 4 ++-- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/SRC/cgeqp3rk.f b/SRC/cgeqp3rk.f index 59e26f8777..d60476f2fd 100755 --- a/SRC/cgeqp3rk.f +++ b/SRC/cgeqp3rk.f @@ -579,8 +579,8 @@ *> \verbatim *> *> November 2023, Igor Kozachenko, James Demmel, -*> Computer Science Division, -*> University of California, Berkeley +*> Computer Science Division, EECS Department, +*> University of California, Berkeley, USA. *> *> \endverbatim * diff --git a/SRC/claqp2rk.f b/SRC/claqp2rk.f index 7645e5a18b..d0f5878453 100755 --- a/SRC/claqp2rk.f +++ b/SRC/claqp2rk.f @@ -332,8 +332,8 @@ *> \verbatim *> *> November 2023, Igor Kozachenko, James Demmel, -*> Computer Science Division, -*> University of California, Berkeley +*> Computer Science Division, EECS Department, +*> University of California, Berkeley, USA. *> *> \endverbatim * diff --git a/SRC/claqp3rk.f b/SRC/claqp3rk.f index c85c2e1c2a..f375f0000e 100755 --- a/SRC/claqp3rk.f +++ b/SRC/claqp3rk.f @@ -383,8 +383,8 @@ *> \verbatim *> *> November 2023, Igor Kozachenko, James Demmel, -*> Computer Science Division, -*> University of California, Berkeley +*> Computer Science Division, EECS Department, +*> University of California, Berkeley, USA. *> *> \endverbatim * diff --git a/SRC/zgeqp3rk.f b/SRC/zgeqp3rk.f index 305247be1b..7f4e3b01b2 100755 --- a/SRC/zgeqp3rk.f +++ b/SRC/zgeqp3rk.f @@ -579,8 +579,8 @@ *> \verbatim *> *> November 2023, Igor Kozachenko, James Demmel, -*> Computer Science Division, -*> University of California, Berkeley +*> Computer Science Division, EECS Department, +*> University of California, Berkeley, USA. *> *> \endverbatim * diff --git a/SRC/zlaqp2rk.f b/SRC/zlaqp2rk.f index f9f1c4c700..c9f7daddbc 100755 --- a/SRC/zlaqp2rk.f +++ b/SRC/zlaqp2rk.f @@ -332,8 +332,8 @@ *> \verbatim *> *> November 2023, Igor Kozachenko, James Demmel, -*> Computer Science Division, -*> University of California, Berkeley +*> Computer Science Division, EECS Department, +*> University of California, Berkeley, USA. *> *> \endverbatim * diff --git a/SRC/zlaqp3rk.f b/SRC/zlaqp3rk.f index e5777633f2..da94f94e33 100755 --- a/SRC/zlaqp3rk.f +++ b/SRC/zlaqp3rk.f @@ -383,8 +383,8 @@ *> \verbatim *> *> November 2023, Igor Kozachenko, James Demmel, -*> Computer Science Division, -*> University of California, Berkeley +*> Computer Science Division, EECS Department, +*> University of California, Berkeley, USA. *> *> \endverbatim * From bd4455fb82eef746ddff9a3bb90e14eb99bbc0a3 Mon Sep 17 00:00:00 2001 From: scr2016 <1015908+scr2016@users.noreply.github.com> Date: Tue, 21 Nov 2023 03:02:10 -0800 Subject: [PATCH 3/3] updated descriptions for the truncated QR routines second time --- SRC/cgeqp3rk.f | 2 +- SRC/claqp2rk.f | 2 +- SRC/claqp3rk.f | 2 +- SRC/dgeqp3rk.f | 4 ++-- SRC/dlaqp2rk.f | 4 ++-- SRC/dlaqp3rk.f | 4 ++-- SRC/sgeqp3rk.f | 4 ++-- SRC/slaqp2rk.f | 4 ++-- SRC/slaqp3rk.f | 4 ++-- SRC/zgeqp3rk.f | 2 +- SRC/zlaqp2rk.f | 2 +- SRC/zlaqp3rk.f | 2 +- 12 files changed, 18 insertions(+), 18 deletions(-) diff --git a/SRC/cgeqp3rk.f b/SRC/cgeqp3rk.f index d60476f2fd..5878606840 100755 --- a/SRC/cgeqp3rk.f +++ b/SRC/cgeqp3rk.f @@ -579,7 +579,7 @@ *> \verbatim *> *> November 2023, Igor Kozachenko, James Demmel, -*> Computer Science Division, EECS Department, +*> EECS Department, *> University of California, Berkeley, USA. *> *> \endverbatim diff --git a/SRC/claqp2rk.f b/SRC/claqp2rk.f index d0f5878453..6b1db085aa 100755 --- a/SRC/claqp2rk.f +++ b/SRC/claqp2rk.f @@ -332,7 +332,7 @@ *> \verbatim *> *> November 2023, Igor Kozachenko, James Demmel, -*> Computer Science Division, EECS Department, +*> EECS Department, *> University of California, Berkeley, USA. *> *> \endverbatim diff --git a/SRC/claqp3rk.f b/SRC/claqp3rk.f index f375f0000e..3703bcbd65 100755 --- a/SRC/claqp3rk.f +++ b/SRC/claqp3rk.f @@ -383,7 +383,7 @@ *> \verbatim *> *> November 2023, Igor Kozachenko, James Demmel, -*> Computer Science Division, EECS Department, +*> EECS Department, *> University of California, Berkeley, USA. *> *> \endverbatim diff --git a/SRC/dgeqp3rk.f b/SRC/dgeqp3rk.f index ace97b712b..117a68287f 100755 --- a/SRC/dgeqp3rk.f +++ b/SRC/dgeqp3rk.f @@ -573,8 +573,8 @@ *> \verbatim *> *> November 2023, Igor Kozachenko, James Demmel, -*> Computer Science Division, -*> University of California, Berkeley +*> EECS Department, +*> University of California, Berkeley, USA. *> *> \endverbatim * diff --git a/SRC/dlaqp2rk.f b/SRC/dlaqp2rk.f index b5a84d0de1..aecd6bb69c 100755 --- a/SRC/dlaqp2rk.f +++ b/SRC/dlaqp2rk.f @@ -331,8 +331,8 @@ *> \verbatim *> *> November 2023, Igor Kozachenko, James Demmel, -*> Computer Science Division, -*> University of California, Berkeley +*> EECS Department, +*> University of California, Berkeley, USA. *> *> \endverbatim * diff --git a/SRC/dlaqp3rk.f b/SRC/dlaqp3rk.f index 39e617d0e1..8139345ed7 100755 --- a/SRC/dlaqp3rk.f +++ b/SRC/dlaqp3rk.f @@ -389,8 +389,8 @@ *> \verbatim *> *> November 2023, Igor Kozachenko, James Demmel, -*> Computer Science Division, -*> University of California, Berkeley +*> EECS Department, +*> University of California, Berkeley, USA. *> *> \endverbatim * diff --git a/SRC/sgeqp3rk.f b/SRC/sgeqp3rk.f index 17559c7f44..bb5da72dc2 100755 --- a/SRC/sgeqp3rk.f +++ b/SRC/sgeqp3rk.f @@ -573,8 +573,8 @@ *> \verbatim *> *> November 2023, Igor Kozachenko, James Demmel, -*> Computer Science Division, -*> University of California, Berkeley +*> EECS Department, +*> University of California, Berkeley, USA. *> *> \endverbatim * diff --git a/SRC/slaqp2rk.f b/SRC/slaqp2rk.f index d3dbb3d7c1..f88b0ce909 100755 --- a/SRC/slaqp2rk.f +++ b/SRC/slaqp2rk.f @@ -331,8 +331,8 @@ *> \verbatim *> *> November 2023, Igor Kozachenko, James Demmel, -*> Computer Science Division, -*> University of California, Berkeley +*> EECS Department, +*> University of California, Berkeley, USA. *> *> \endverbatim * diff --git a/SRC/slaqp3rk.f b/SRC/slaqp3rk.f index fa735bb9d7..b2dc2b334c 100755 --- a/SRC/slaqp3rk.f +++ b/SRC/slaqp3rk.f @@ -389,8 +389,8 @@ *> \verbatim *> *> November 2023, Igor Kozachenko, James Demmel, -*> Computer Science Division, -*> University of California, Berkeley +*> EECS Department, +*> University of California, Berkeley, USA. *> *> \endverbatim * diff --git a/SRC/zgeqp3rk.f b/SRC/zgeqp3rk.f index 7f4e3b01b2..247a3c3797 100755 --- a/SRC/zgeqp3rk.f +++ b/SRC/zgeqp3rk.f @@ -579,7 +579,7 @@ *> \verbatim *> *> November 2023, Igor Kozachenko, James Demmel, -*> Computer Science Division, EECS Department, +*> EECS Department, *> University of California, Berkeley, USA. *> *> \endverbatim diff --git a/SRC/zlaqp2rk.f b/SRC/zlaqp2rk.f index c9f7daddbc..f6bf555c26 100755 --- a/SRC/zlaqp2rk.f +++ b/SRC/zlaqp2rk.f @@ -332,7 +332,7 @@ *> \verbatim *> *> November 2023, Igor Kozachenko, James Demmel, -*> Computer Science Division, EECS Department, +*> EECS Department, *> University of California, Berkeley, USA. *> *> \endverbatim diff --git a/SRC/zlaqp3rk.f b/SRC/zlaqp3rk.f index da94f94e33..0dd8bf8e35 100755 --- a/SRC/zlaqp3rk.f +++ b/SRC/zlaqp3rk.f @@ -383,7 +383,7 @@ *> \verbatim *> *> November 2023, Igor Kozachenko, James Demmel, -*> Computer Science Division, EECS Department, +*> EECS Department, *> University of California, Berkeley, USA. *> *> \endverbatim