fixed comments: specify which norm is used (no.1 from PR #562) #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PACK#562) Despite the recommendation, no change has been made in xGBT02, xGET02, xGTT02, xTBT02, xTPT02, and xTRT02 for C,Z datatypes yet: as it was noted afterwards in PR Reference-LAPACK#571, those routines are using mixed types of norm: 1-norm for op(A) and taxicab-based norm |Re(z)|+|Im(z)| for residual.
Codecov Report
@@ Coverage Diff @@
## master #581 +/- ##
=======================================
Coverage 82.37% 82.37%
=======================================
Files 1894 1894
Lines 190679 190679
=======================================
Hits 157065 157065
Misses 33614 33614 Continue to review full report at Codecov.
|
weslleyspereira
approved these changes
Jun 9, 2021
Collaborator
weslleyspereira
left a comment
weslleyspereira
left a comment
There was a problem hiding this comment.
Nice job! Thanks.
langou
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the recommendation, no change has been made in xGBT02, xGET02, xGTT02, xTBT02, xTPT02, and xTRT02 for C,Z datatypes yet: as it was noted afterwards in PR #571, those routines are using mixed types of norm: 1-norm for op(A) and taxicab-based norm |Re(z)|+|Im(z)| for residual.