Skip to content

Commit 3ae32c6

Browse files
committed
Use Optional argument for on(success:failure:).
1 parent 4558963 commit 3ae32c6

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

SwiftTask/SwiftTask.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -546,22 +546,22 @@ public class Task<Progress, Value, Error>: Cancellable, CustomStringConvertible
546546
}.name("\(self.name)-failure")
547547
}
548548

549-
public func on(success success: Value -> Void = { _ in }, failure: ErrorInfo -> Void = { _ in }) -> Self
549+
public func on(success success: (Value -> Void)? = nil, failure: (ErrorInfo -> Void)? = nil) -> Self
550550
{
551551
var dummyCanceller: Canceller? = nil
552552
return self.on(&dummyCanceller, success: success, failure: failure)
553553
}
554554

555-
public func on<C: Canceller>(inout canceller: C?, success: Value -> Void = { _ in }, failure: ErrorInfo -> Void = { _ in }) -> Self
555+
public func on<C: Canceller>(inout canceller: C?, success: (Value -> Void)? = nil, failure: (ErrorInfo -> Void)? = nil) -> Self
556556
{
557557
let selfMachine = self._machine
558558

559559
self._then(&canceller) {
560560
if let value = selfMachine.value.rawValue {
561-
success(value)
561+
success?(value)
562562
}
563563
else if let errorInfo = selfMachine.errorInfo.rawValue {
564-
failure(errorInfo)
564+
failure?(errorInfo)
565565
}
566566
}
567567

0 commit comments

Comments
 (0)