Skip to content

Commit c4af0d9

Browse files
refactor: move opts into scope, semantic naming for conditionals
1 parent ca495dd commit c4af0d9

File tree

2 files changed

+8
-4
lines changed
  • packages

2 files changed

+8
-4
lines changed

packages/qwik-router/src/buildtime/vite/plugin.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,9 @@ function qwikRouterPlugin(userOpts?: QwikRouterVitePluginOptions): any {
215215
},
216216

217217
async transform(code, id) {
218-
if (id.startsWith('\0')) {
218+
const isVirtualId = id.startsWith('\0');
219+
220+
if (isVirtualId) {
219221
return;
220222
}
221223
const ext = extname(id).toLowerCase();

packages/qwik/src/optimizer/src/plugins/vite.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -410,27 +410,29 @@ export function qwikVite(qwikViteOpts: QwikVitePluginOptions = {}): any {
410410

411411
resolveId(id, importer, resolveIdOpts) {
412412
const shouldResolveFile = fileFilter(id, 'resolveId');
413+
const isDevClientModule = isClientDevOnly && id === VITE_CLIENT_MODULE;
413414

414415
if (isVirtualId(id) || !shouldResolveFile) {
415416
return null;
416417
}
417-
if (isClientDevOnly && id === VITE_CLIENT_MODULE) {
418+
if (isDevClientModule) {
418419
return id;
419420
}
420421
return qwikPlugin.resolveId(this, id, importer, resolveIdOpts);
421422
},
422423

423424
load(id, loadOpts) {
424425
const shouldLoadFile = fileFilter(id, 'load');
426+
const isDevClientModule = isClientDevOnly && id === VITE_CLIENT_MODULE;
425427

426428
if (isVirtualId(id) || !shouldLoadFile) {
427429
return null;
428430
}
429431

430432
id = qwikPlugin.normalizePath(id);
431-
const opts = qwikPlugin.getOptions();
432433

433-
if (isClientDevOnly && id === VITE_CLIENT_MODULE) {
434+
if (isDevClientModule) {
435+
const opts = qwikPlugin.getOptions();
434436
return getViteDevModule(opts);
435437
}
436438
if (viteCommand === 'serve' && id.endsWith(QWIK_CLIENT_MANIFEST_ID)) {

0 commit comments

Comments
 (0)