First attempt to fix #19

Author: beberlei

src/main/QafooLabs/Refactoring/Domain/Model/PhpName.php

@@ -65,6 +65,10 @@ public function change(PhpName $from, PhpName $to)
             return $this;
         }
 
+        if ($this->equals($from)) {
+            return $to;
+        }
+
         $toParts = explode("\\",   $to->fullyQualifiedName);
         $thisParts = explode("\\", $this->fullyQualifiedName);
 
@@ -100,4 +104,10 @@ public function relativeName()
     {
         return $this->relativeName;
     }
+
+    public function equals(PhpName $other)
+    {
+        return $this->fullyQualifiedName === $other->fullyQualifiedName &&
+               $this->relativeName === $other->relativeName;
+    }
 }

src/test/QafooLabs/Refactoring/Adapters/PHPParser/ParserPhpNameScannerTest.php

@@ -17,10 +17,12 @@ public function testFindNames()
             array(
                 new PhpName('QafooLabs\Refactoring\Domain\Model\File', 'QafooLabs\Refactoring\Domain\Model\File', $file, 5),
                 new PhpName('QafooLabs\Refactoring\Domain\Model\PhpName', 'QafooLabs\Refactoring\Domain\Model\PhpName', $file, 6),
+                new PhpName('QafooLabs\Refactoring\Adapters\PHPParser\PHPUnit_Framework_TestCase', 'PHPUnit_Framework_TestCase', $file, 8),
                 new PhpName('QafooLabs\Refactoring\Domain\Model\File', 'File', $file, 12),
                 new PhpName('QafooLabs\Refactoring\Adapters\PHPParser\ParserPhpNameScanner', 'ParserPhpNameScanner', $file, 13),
             ),
-            array_slice($names, 0, 4)
+            array_slice($names, 0, 5)
         );
     }
 }
+

src/test/QafooLabs/Refactoring/Domain/Model/PhpNameTest.php

@@ -69,4 +69,16 @@ public function testRegression2()
         $this->assertEquals('Foo\\Bar', $changed->fullyQualifiedName());
         $this->assertEquals('Foo\\Bar', $changed->relativeName());
     }
+
+    public function testRegression3()
+    {
+        $name = new PhpName("Foo\\Foo", "Foo\\Foo", null, null);
+        $from = new PhpName("Foo\\Foo", "Foo\\Foo", null, null);
+        $to = new PhpName("Foo\\Bar\\Foo", "Foo\\Bar\\Foo", null, null);
+
+        $changed = $name->change($from, $to);
+
+        $this->assertEquals('Foo\\Bar\\Foo', $changed->fullyQualifiedName());
+        $this->assertEquals('Foo\\Bar\\Foo', $changed->relativeName());
+    }
 }