Skip to content

Fix the broken resource gallery submission validation #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Fix the broken resource gallery submission validation #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17f0720
Move IssueInfo.data initialization from __post_init_post_parse__ to _…
erogluorhan Dec 22, 2023
2821eba
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/collect-user-submission.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,15 @@ class IssueInfo:
gh_event_path: pydantic.FilePath
submission: Submission = pydantic.Field(default=None)

def __post_init_post_parse__(self):
with open(self.gh_event_path) as f:
self.data = json.load(f)

def create_submission(self):
self._get_inputs()
self._create_submission_input()
return self

def _get_inputs(self):
with open(self.gh_event_path) as f:
self.data = json.load(f)

self.author = self.data['issue']['user']['login']
self.title = self.data['issue']['title']
self.body = self.data['issue']['body']
Expand Down
6 changes: 3 additions & 3 deletions portal/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,9 @@ the example data used by the [Pythia Foundations Book](https://foundations.proje

## Join us!

If you have questions or want to share anything with the Project
Pythia Team, please reach out to us through the [Project Pythia
category on the Pangeo Discourse forum](https://discourse.pangeo.io/c/education/project-pythia/)
If you have questions or want to share anything with the Project
Pythia Team, please reach out to us through the [Project Pythia
category on the Pangeo Discourse forum](https://discourse.pangeo.io/c/education/project-pythia/)
below or join us at our [Weekly Working Group Meetings](#weekly-working-group-meetings).

<span class="d-flex justify-content-center pt-1 pb-4">
Expand Down