Dismissal of Stale Reviews

[jukent]

Currently if I were to update a Pull Request (even just upstream changes already in the main code base because of a recently merged PR), the way this repository is set up -- it will dismiss everyone's reviews.

Now I understand the value in this. Say, I get enough approving reviews and then make egregious changes to the incoming branch that are then merged that would be very bad.

However, I think we can trust each other to re-request review when altering a PR, and I believe that the current dismissal of reviews is a little aggressive and creates more work for everyone.

We can disable this with: Settings ▶ Branches ▶ Branch protection rules ▶ Edit ▶ Uncheck "Dismiss stale pull request approvals when new commits are pushed".

Would anyone else like for this setting to be changed? Or feel we should keep it as is?

[jukent]

Actually that seems not to be true. I can "Update branch" without dismissing reviews.