Skip to content

Commit 80f706b

Browse files
committed
refactor: replace NativeScriptModule with NativeScriptCommonModule
imports NativeScriptModule should be imported only in the root NgModule. For all other feature modules, NativeScriptCommonModule should be used instead. Check out: NativeScript/nativescript-angular#1196
1 parent e1a1141 commit 80f706b

File tree

7 files changed

+33
-26
lines changed

7 files changed

+33
-26
lines changed

sdkAngular/app/autocomplete/autocomplete-examples.module.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1+
;
2+
import { NativeScriptCommonModule } from "nativescript-angular/common";
13
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
2-
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
34

45
import { NativeScriptRouterModule } from "nativescript-angular/router";
56
import { NativeScriptUIAutoCompleteTextViewModule } from "nativescript-ui-autocomplete/angular";
@@ -28,11 +29,11 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
2829
@NgModule({
2930
schemas: [NO_ERRORS_SCHEMA],
3031
imports: [
31-
NativeScriptModule,
3232
CommonDirectivesModule,
3333
NativeScriptUIAutoCompleteTextViewModule,
3434
NativeScriptRouterModule,
35-
NativeScriptRouterModule.forChild(routes)
35+
NativeScriptRouterModule.forChild(routes),
36+
NativeScriptCommonModule,
3637
],
3738
declarations: [
3839
AutoCompleteContainsModeComponent,

sdkAngular/app/calendar/calendar-examples.module.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1+
;
2+
import { NativeScriptCommonModule } from "nativescript-angular/common";
13
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
2-
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
34

45
import { NativeScriptRouterModule } from "nativescript-angular/router";
56
import { NativeScriptUICalendarModule } from "nativescript-ui-calendar/angular";
@@ -21,12 +22,12 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
2122
@NgModule({
2223
schemas: [NO_ERRORS_SCHEMA],
2324
imports: [
24-
NativeScriptModule,
2525
CommonDirectivesModule,
2626
NativeScriptUICalendarModule,
2727
NativeScriptUIListViewModule,
2828
NativeScriptRouterModule,
29-
NativeScriptRouterModule.forChild(routes)
29+
NativeScriptRouterModule.forChild(routes),
30+
NativeScriptCommonModule,
3031
],
3132
declarations: [
3233
CalendarLocalizationComponent,

sdkAngular/app/chart/chart-examples.module.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1+
;
2+
import { NativeScriptCommonModule } from "nativescript-angular/common";
13
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
2-
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
34

45
import { NativeScriptRouterModule } from "nativescript-angular/router";
56
import { NativeScriptUIChartModule } from "nativescript-ui-chart/angular";
@@ -44,11 +45,11 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
4445
@NgModule({
4546
schemas: [NO_ERRORS_SCHEMA],
4647
imports: [
47-
NativeScriptModule,
4848
CommonDirectivesModule,
4949
NativeScriptUIChartModule,
5050
NativeScriptRouterModule,
51-
NativeScriptRouterModule.forChild(routes)
51+
NativeScriptRouterModule.forChild(routes),
52+
NativeScriptCommonModule,
5253
],
5354
declarations: [
5455
ChartAnnotationsGridLineComponent,
@@ -86,4 +87,4 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
8687
ChartLabelVisibilityComponent
8788
]
8889
})
89-
export class ChartExamplesModule { }
90+
export class ChartExamplesModule { }

sdkAngular/app/dataform/dataform-examples.module.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1+
;
2+
import { NativeScriptCommonModule } from "nativescript-angular/common";
13
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
2-
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
34

45
import { NativeScriptRouterModule } from "nativescript-angular/router";
56
import { NativeScriptUIDataFormModule } from "nativescript-ui-dataform/angular";
@@ -42,11 +43,11 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
4243
@NgModule({
4344
schemas: [NO_ERRORS_SCHEMA],
4445
imports: [
45-
NativeScriptModule,
4646
CommonDirectivesModule,
4747
NativeScriptUIDataFormModule,
4848
NativeScriptRouterModule,
49-
NativeScriptRouterModule.forChild(routes)
49+
NativeScriptRouterModule.forChild(routes),
50+
NativeScriptCommonModule,
5051
],
5152
declarations: [
5253
DataFormAdjustmentComponent,
@@ -82,4 +83,4 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
8283
DataFormValueProvidersComponent,
8384
]
8485
})
85-
export class DataFormExamplesModule { }
86+
export class DataFormExamplesModule { }

sdkAngular/app/gauges/gauges-examples.module.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1+
;
2+
import { NativeScriptCommonModule } from "nativescript-angular/common";
13
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
2-
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
34

45
import { NativeScriptRouterModule } from "nativescript-angular/router";
56
import { NativeScriptUIGaugeModule } from "nativescript-ui-gauge/angular";
@@ -15,11 +16,11 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
1516
@NgModule({
1617
schemas: [NO_ERRORS_SCHEMA],
1718
imports: [
18-
NativeScriptModule,
1919
CommonDirectivesModule,
2020
NativeScriptUIGaugeModule,
2121
NativeScriptRouterModule,
22-
NativeScriptRouterModule.forChild(routes)
22+
NativeScriptRouterModule.forChild(routes),
23+
NativeScriptCommonModule,
2324
],
2425
declarations: [
2526
GaugesAnimationsComponent,
@@ -28,4 +29,4 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
2829
GaugesScalesComponent
2930
]
3031
})
31-
export class GaugesExamplesModule { }
32+
export class GaugesExamplesModule { }

sdkAngular/app/listview/listview-examples.module.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1+
;
2+
import { NativeScriptCommonModule } from "nativescript-angular/common";
13
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
2-
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
34

45
import { NativeScriptRouterModule } from "nativescript-angular/router";
56
import { NativeScriptFormsModule } from "nativescript-angular/forms";
@@ -46,12 +47,12 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
4647
@NgModule({
4748
schemas: [NO_ERRORS_SCHEMA],
4849
imports: [
49-
NativeScriptModule,
5050
CommonDirectivesModule,
5151
NativeScriptUIListViewModule,
5252
NativeScriptFormsModule,
5353
NativeScriptRouterModule,
54-
NativeScriptRouterModule.forChild(routes)
54+
NativeScriptRouterModule.forChild(routes),
55+
NativeScriptCommonModule,
5556
],
5657
declarations: [
5758
ListViewGettingStartedComponent,
@@ -90,4 +91,4 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
9091
ListViewDataOperationsSortingComponent
9192
]
9293
})
93-
export class ListViewExamplesModule { }
94+
export class ListViewExamplesModule { }

sdkAngular/app/sidedrawer/sidedrawer-examples.module.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1+
;
2+
import { NativeScriptCommonModule } from "nativescript-angular/common";
13
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
2-
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
34

45
import { NativeScriptRouterModule } from "nativescript-angular/router";
56
import { NativeScriptUISideDrawerModule } from "nativescript-ui-sidedrawer/angular";
@@ -17,11 +18,11 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
1718
@NgModule({
1819
schemas: [NO_ERRORS_SCHEMA],
1920
imports: [
20-
NativeScriptModule,
2121
CommonDirectivesModule,
2222
NativeScriptUISideDrawerModule,
2323
NativeScriptRouterModule,
24-
NativeScriptRouterModule.forChild(routes)
24+
NativeScriptRouterModule.forChild(routes),
25+
NativeScriptCommonModule,
2526
],
2627
declarations: [
2728
SideDrawerEventsComponent,
@@ -32,4 +33,4 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
3233
SideDrawerTransitionsComponent
3334
]
3435
})
35-
export class SideDrawerExamplesModule { }
36+
export class SideDrawerExamplesModule { }

0 commit comments

Comments
 (0)