Enable 'await-thenable', 'unbound-method' and 'restrict-plus-operands'

Author: andyleejordan

.eslintrc.json

@@ -52,6 +52,15 @@
     "@typescript-eslint/no-floating-promises": [
       "error"
     ],
+    "@typescript-eslint/await-thenable": [
+      "error"
+    ],
+    "@typescript-eslint/unbound-method": [
+      "error"
+    ],
+    "@typescript-eslint/restrict-plus-operands": [
+      "error"
+    ],
     "header/header": [
       2,
       "line",

src/features/HelpCompletion.ts

@@ -36,9 +36,7 @@ export class HelpCompletionFeature extends LanguageClientConsumer {
 
         if (this.settings.helpCompletion !== Settings.CommentType.Disabled) {
             this.helpCompletionProvider = new HelpCompletionProvider();
-            const subscriptions: Disposable[] = [];
-            workspace.onDidChangeTextDocument(this.onEvent, this, subscriptions);
-            this.disposable = Disposable.from(...subscriptions);
+            this.disposable = workspace.onDidChangeTextDocument(async (e) => { await this.onEvent(e); });
         }
     }
 

src/features/OpenInISE.ts

@@ -26,7 +26,7 @@ export class OpenInISEFeature implements vscode.Disposable {
 
             ISEPath += "\\WindowsPowerShell\\v1.0\\powershell_ise.exe";
 
-            ChildProcess.exec(ISEPath + ` -File "${uri.fsPath}"`).unref();
+            ChildProcess.exec(`${ISEPath} -File "${uri.fsPath}"`).unref();
         });
     }
 

src/logging.ts

@@ -126,7 +126,7 @@ export class Logger implements ILogger {
         if (choice) {
             for (const action of fullActions) {
                 if (choice === action.prompt) {
-                    await action.action();
+                    action.action();
                     return;
                 }
             }

src/platform.ts

@@ -4,6 +4,7 @@
 import * as os from "os";
 import * as path from "path";
 import * as process from "process";
+import { integer } from "vscode-languageserver-protocol";
 import { IPowerShellAdditionalExePathSettings } from "./settings";
 
 // This uses require so we can rewire it in unit tests!
@@ -339,7 +340,7 @@ export class PowerShellExeFinder {
                 // We are looking for something like "7-preview"
 
                 // Preview dirs all have dashes in them
-                const dashIndex = item.indexOf("-");
+                const dashIndex: integer = item.indexOf("-");
                 if (dashIndex < 0) {
                     continue;
                 }

src/session.ts

@@ -232,7 +232,7 @@ export class SessionManager implements Middleware {
 
     public getNewSessionFilePath(): vscode.Uri {
         const uniqueId: number = Math.floor(100000 + Math.random() * 900000);
-        return vscode.Uri.joinPath(this.sessionsFolder, "PSES-VSCode-" + process.env.VSCODE_PID + "-" + uniqueId + ".json");
+        return vscode.Uri.joinPath(this.sessionsFolder, `PSES-VSCode-${process.env.VSCODE_PID}-${uniqueId}.json`);
     }
 
     public async createDebugSessionProcess(settings: Settings.ISettings): Promise<PowerShellProcess> {

test/core/platform.test.ts

@@ -719,9 +719,9 @@ describe("Platform module", function () {
                 const defaultPowerShell = await powerShellExeFinder.getFirstAvailablePowerShellInstallation();
                 const expectedPowerShell = testPlatform.expectedPowerShellSequence[0];
 
-                assert.strictEqual(defaultPowerShell.exePath, expectedPowerShell!.exePath);
-                assert.strictEqual(defaultPowerShell.displayName, expectedPowerShell!.displayName);
-                assert.strictEqual(defaultPowerShell.supportsProperArguments, expectedPowerShell!.supportsProperArguments);
+                assert.strictEqual(defaultPowerShell.exePath, expectedPowerShell.exePath);
+                assert.strictEqual(defaultPowerShell.displayName, expectedPowerShell.displayName);
+                assert.strictEqual(defaultPowerShell.supportsProperArguments, expectedPowerShell.supportsProperArguments);
             });
         }
 
@@ -755,9 +755,9 @@ describe("Platform module", function () {
                     const foundPowerShell = foundPowerShells[i];
                     const expectedPowerShell = testPlatform.expectedPowerShellSequence[i];
 
-                    assert.strictEqual(foundPowerShell && foundPowerShell.exePath, expectedPowerShell!.exePath);
-                    assert.strictEqual(foundPowerShell && foundPowerShell.displayName, expectedPowerShell!.displayName);
-                    assert.strictEqual(foundPowerShell && foundPowerShell.supportsProperArguments, expectedPowerShell!.supportsProperArguments);
+                    assert.strictEqual(foundPowerShell && foundPowerShell.exePath, expectedPowerShell.exePath);
+                    assert.strictEqual(foundPowerShell && foundPowerShell.displayName, expectedPowerShell.displayName);
+                    assert.strictEqual(foundPowerShell && foundPowerShell.supportsProperArguments, expectedPowerShell.supportsProperArguments);
                 }
 
                 assert.strictEqual(