-
Notifications
You must be signed in to change notification settings - Fork 240
Bump Newtonsoft.Json from 12.0.2 to 13.0.1 #1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
|
@dependabot recreate |
|
Looks like this PR is closed. If you re-open it I'll rebase it as long as no-one else has edited it (you can use |
|
@dependabot reopen |
|
@rjmholt I had the bot reopen and rebase this because upon inspection, OmniSharp is using 11.x and we're already on 12.x, so the argument of staying at OmniSharp's version is invalid. We should either downgrade to 11.x or upgrade to 13.x if it causes no problems. |
Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.2 to 13.0.1. - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases) - [Commits](JamesNK/Newtonsoft.Json@12.0.2...13.0.1) Signed-off-by: dependabot[bot] <[email protected]>
89b6a61 to
d1a338e
Compare
|
Our issue here is needing to be compatible with the oldest version of Newtonsoft.Json shipped in a PowerShell we support, which I think is going to be in 7.0 |
|
Ah, that's good to know! |
|
Ok, some documentation: PowerShell 7.0.0 uses Newtonsoft.Json 12.0.3. The upcoming release PowerShell 7.2.0 release uses Newtonsoft.Json 13.0.1. So we'll ignore this until such time that we ever drop 7.0.0 support or reconsider this coupling. |
|
@dependabot ignore this major version |
|
OK, I won't notify you about version 13.x.x again, unless you re-open this PR or update to a 13.x.x release yourself. |
Bumps Newtonsoft.Json from 12.0.2 to 13.0.1.
Release notes
Sourced from Newtonsoft.Json's releases.
Commits
ae9fe44Remove compiler package and update sourcelink (#2498)8ef6621Remove prerelease for 13.0.111331f5Update SDK to 5.0.200 (#2495)c7e8abcUpdate to 13.0.1-beta21745d7cFix JTokenWriter when writing comment to an object (#2493)583eb12Fix missing error when deserializing JToken with a contract type mismatch (#2...b6dc05bChange MaxDepth default to 64 (#2473)15525f1Fix JsonWriter.WriteToken to allow null with string token (#2472)926d2f0Enable embed untracked sources (#2471)0a56633Fixes #2372 - variable typos (#2465)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)