Bring back PSES tests #1190
Merged
Bring back PSES tests #1190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
commented
Feb 12, 2020
|
|
||
| [Fact] | ||
| [Trait("Category", "Symbols")] | ||
| [Fact(Skip = "TODO Fix this test. A possible bug in PSES product code.")] |
TylerLeonhardt
commented
Feb 12, 2020
| [Fact] | ||
| public async Task LanguageServiceFindsReferencesOnCommandWithAlias() | ||
| [Trait("Category", "Symbols")] | ||
| [Fact(Skip = "TODO Fix this test. A possible bug in PSES product code.")] |
TylerLeonhardt
commented
Feb 12, 2020
| [Fact] | ||
| public async Task LanguageServiceFindsReferencesOnAlias() | ||
| [Trait("Category", "Symbols")] | ||
| [Fact(Skip = "TODO Fix this test. A possible bug in PSES product code.")] |
rjmholt
approved these changes
Feb 14, 2020
Contributor
rjmholt
left a comment
rjmholt
left a comment
There was a problem hiding this comment.
LGTM, but merging this will mean rebasing the API PR
TylerLeonhardt
force-pushed
the
bring-back-pses-tests
branch
from
db0615f to
119e220
Compare
Member
Author
|
Issues
======
+ Solved 59
- Added 2
Complexity increasing per file
==============================
- src/PowerShellEditorServices/Services/TextDocument/FoldingReference.cs 3
Complexity decreasing per file
==============================
+ test/PowerShellEditorServices.Test/Extensions/ExtensionServiceTests.cs -1
+ test/PowerShellEditorServices.Test/Debugging/DebugServiceTests.cs -2
Clones added
============
- test/PowerShellEditorServices.Test/Language/LanguageServiceTests.cs 2
Clones removed
==============
+ test/PowerShellEditorServices.Test/Debugging/DebugServiceTests.cs -53
See the complete overview on Codacy |
TylerLeonhardt
commented
Feb 18, 2020
| // // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
| // // | ||
|
|
||
| // using Microsoft.PowerShell.EditorServices.Utility; |
Member
Author
There was a problem hiding this comment.
Out of scope. See TODO at the top of the file.
TylerLeonhardt
commented
Feb 18, 2020
| // // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
| // // | ||
|
|
||
| // using Microsoft.Extensions.Logging.Abstractions; |
Member
Author
There was a problem hiding this comment.
Out of scope. See TODO at the top of the file.
rjmholt
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back the tests from
PowerShellEditorServices.Test. We get a total of 157 tests coming in (with 3 skipped that I commented on).I think there's opportunity for some refactoring later:
LanguageServiceTests.csshould be broken down into the service tests that it's testingHere are the details:
Tests that work:
test/PowerShellEditorServices.Test/Console/ChoicePromptHandlerTests.cstest/PowerShellEditorServices.Test/Language/LanguageServiceTests.cstest/PowerShellEditorServices.Test/Language/TokenOperationsTests.cstest/PowerShellEditorServices.Test/Session/PathEscapingTests.cstest/PowerShellEditorServices.Test/Session/PowerShellContextTests.cstest/PowerShellEditorServices.Test/Session/ScriptFileTests.cstest/PowerShellEditorServices.Test/Session/WorkspaceTests.cstest/PowerShellEditorServices.Test/Utility/AsyncLockTests.cstest/PowerShellEditorServices.Test/Utility/AsyncQueueTests.cstest/PowerShellEditorServices.Test/Console/InputPromptHandlerTests.csTests that don't work that I'm calling out of scope:
test/PowerShellEditorServices.Test/Debugging/DebugServiceTests.cstest/PowerShellEditorServices.Test/Extensions/ExtensionServiceTests.csTests that no longer apply in their current form:
test/PowerShellEditorServices.Test/Utility/AsyncDebouncerTests.cstest/PowerShellEditorServices.Test/Utility/ExecutionTimerTests.cstest/PowerShellEditorServices.Test/Utility/LoggerTests.cstest/PowerShellEditorServices.Test/Utility/ObjectPoolTests.cstest/PowerShellEditorServices.Test/Console/ConsoleServiceTests.cs