Handle incomingSettings and profileObject being null (#1504)

* Added null check for incomingSettings.Powershell to prevent SendFeatureChangesTelemetry from throwing an exception when accessing Powershell and its properties.

* Added null check in GetProfilePathFromProfileObject to prevent NullReferenceException if profileObject is null.

Co-authored-by: Andrew Schwartzmeyer <[email protected]>

Author: dkattan

src/PowerShellEditorServices.Hosting/Commands/StartEditorServicesCommand.cs

@@ -378,7 +378,10 @@ private EditorServicesConfig CreateConfigObject()
         private string GetProfilePathFromProfileObject(PSObject profileObject, ProfileUserKind userKind, ProfileHostKind hostKind)
         {
             string profilePathName = $"{userKind}{hostKind}";
-
+            if (profileObject is null)
+            {
+                return null;
+            }
             string pwshProfilePath = (string)profileObject.Properties[profilePathName].Value;
 
             if (hostKind == ProfileHostKind.AllHosts)

src/PowerShellEditorServices/Services/Workspace/Handlers/ConfigurationHandler.cs

@@ -51,7 +51,7 @@ public override async Task<Unit> Handle(DidChangeConfigurationParams request, Ca
         {
             LanguageServerSettingsWrapper incomingSettings = request.Settings.ToObject<LanguageServerSettingsWrapper>();
             this._logger.LogTrace("Handling DidChangeConfiguration");
-            if (incomingSettings == null)
+            if (incomingSettings is null || incomingSettings.Powershell is null)
             {
                 this._logger.LogTrace("Incoming settings were null");
                 return await Unit.Task.ConfigureAwait(false);