Fix process exit throwing

Author: rjmholt

src/PowerShellEditorServices/Services/PowerShell/Handlers/EvaluateHandler.cs

@@ -7,6 +7,7 @@
 using Microsoft.Extensions.Logging;
 using Microsoft.PowerShell.EditorServices.Services.PowerShell;
 using Microsoft.PowerShell.EditorServices.Services.PowerShell.Execution;
+using Microsoft.PowerShell.EditorServices.Utility;
 
 namespace Microsoft.PowerShell.EditorServices.Handlers
 {
@@ -36,7 +37,8 @@ public Task<EvaluateResponseBody> Handle(EvaluateRequestArguments request, Cance
             _executionService.ExecutePSCommandAsync(
                 new PSCommand().AddScript(request.Expression),
                 CancellationToken.None,
-                new PowerShellExecutionOptions { WriteInputToHost = true, WriteOutputToHost = true, AddToHistory = true, ThrowOnError = false, InterruptCurrentForeground = true });
+                new PowerShellExecutionOptions { WriteInputToHost = true, WriteOutputToHost = true, AddToHistory = true, ThrowOnError = false, InterruptCurrentForeground = true })
+                .HandleErrorsAsync(_logger);
 
             return Task.FromResult(new EvaluateResponseBody
             {

test/PowerShellEditorServices.Test.E2E/Processes/StdioServerProcess.cs

@@ -118,15 +118,15 @@ public override Task Start()
         /// <summary>
         ///     Stop or disconnect from the server.
         /// </summary>
-        public override async Task Stop()
+        public override Task Stop()
         {
             Process serverProcess = Interlocked.Exchange(ref _serverProcess, null);
+            ServerExitCompletion.TrySetResult(null);
             if (serverProcess != null && !serverProcess.HasExited)
             {
                 serverProcess.Kill();
             }
-
-            await ServerExitCompletion.Task.ConfigureAwait(false);
+            return ServerExitCompletion.Task;
         }
 
         public event EventHandler<ProcessExitedArgs> ProcessExited;