WIP: Fixed variable scope for set var

Author: andyleejordan

src/PowerShellEditorServices/Services/DebugAdapter/DebugService.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using System;
@@ -394,25 +394,21 @@ public async Task<string> SetVariableAsync(int variableContainerReferenceId, str
             }
 
             VariableDetailsBase variable = variableContainer.Children[name];
-            // Determine scope in which the variable lives so we can pass it to `Get-Variable -Scope`.
-            string scope = null; // TODO: Can this use a fancy pattern matcher?
-            if (variableContainerReferenceId == localScopeVariables.Id)
-            {
-                scope = VariableContainerDetails.LocalScopeName;
-            }
-            else if (variableContainerReferenceId == scriptScopeVariables.Id)
+            // Determine scope in which the variable lives so we can pass it to `Get-Variable
+            // -Scope`. First we assume that it's in the local scope (which is most likely the
+            // case), and then check if it is instead in the script or global scopes. There may be a
+            // scenario where it's in none of these scopes, in which case things aren't going to
+            // work, but since we can't tie scopes to stack frames, we just have to guess.
+            string scope = VariableContainerDetails.LocalScopeName;
+            // TODO: Can this use a fancy pattern matcher?
+            if (variableContainerReferenceId == scriptScopeVariables.Id)
             {
                 scope = VariableContainerDetails.ScriptScopeName;
             }
             else if (variableContainerReferenceId == globalScopeVariables.Id)
             {
                 scope = VariableContainerDetails.GlobalScopeName;
             }
-            else
-            {
-                // Hmm, this would be unexpected. No scope means do not pass GO, do not collect $200.
-                throw new Exception("Could not find the scope for this variable.");
-            }
 
             // Now that we have the scope, get the associated PSVariable object for the variable to be set.
             var getVariableCommand = new PSCommand()