WIP: InvocationInfo is null?!

Author: andyleejordan

src/PowerShellEditorServices/Services/DebugAdapter/DebugService.cs

@@ -953,7 +953,8 @@ private static string TrimScriptListingLine(PSObject scriptLineObj, ref int pref
         internal async void OnDebuggerStopAsync(object sender, DebuggerStopEventArgs e)
         {
             bool noScriptName = false;
-            string localScriptPath = e.InvocationInfo.ScriptName;
+            // TODO: Why is InvocationInfo sometimes null?
+            string localScriptPath = e.InvocationInfo?.ScriptName;
 
             // If there's no ScriptName, get the "list" of the current source
             if (remoteFileManager is not null && string.IsNullOrEmpty(localScriptPath))
@@ -1013,7 +1014,8 @@ await remoteFileManager.FetchRemoteFileAsync(
             {
                 // Augment the top stack frame with details from the stop event
 
-                if (invocationTypeScriptPositionProperty.GetValue(e.InvocationInfo) is IScriptExtent scriptExtent)
+                if (e.InvocationInfo is not null
+                    && invocationTypeScriptPositionProperty.GetValue(e.InvocationInfo) is IScriptExtent scriptExtent)
                 {
                     stackFrameDetails[0].StartLineNumber = scriptExtent.StartLineNumber;
                     stackFrameDetails[0].EndLineNumber = scriptExtent.EndLineNumber;

src/PowerShellEditorServices/Services/DebugAdapter/Debugging/DebuggerStoppedEventArgs.cs

@@ -1,9 +1,10 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
+using System.Management.Automation;
+using System.Security.Cryptography;
 using Microsoft.PowerShell.EditorServices.Services.PowerShell.Runspace;
 using Microsoft.PowerShell.EditorServices.Utility;
-using System.Management.Automation;
 
 namespace Microsoft.PowerShell.EditorServices.Services.DebugAdapter
 {
@@ -46,7 +47,14 @@ public int LineNumber
         {
             get
             {
-                return this.OriginalEvent.InvocationInfo.ScriptLineNumber;
+                if (OriginalEvent.InvocationInfo is not null)
+                {
+                    return OriginalEvent.InvocationInfo.ScriptLineNumber;
+                }
+                else
+                {
+                    return 1;
+                }
             }
         }
 
@@ -57,7 +65,14 @@ public int ColumnNumber
         {
             get
             {
-                return this.OriginalEvent.InvocationInfo.OffsetInLine;
+                if (OriginalEvent.InvocationInfo is not null)
+                {
+                    return OriginalEvent.InvocationInfo.OffsetInLine;
+                }
+                else
+                {
+                    return 1;
+                }
             }
         }
 
@@ -99,11 +114,11 @@ public DebuggerStoppedEventArgs(
             if (!string.IsNullOrEmpty(localScriptPath))
             {
                 this.ScriptPath = localScriptPath;
-                this.RemoteScriptPath = originalEvent.InvocationInfo.ScriptName;
+                this.RemoteScriptPath = originalEvent.InvocationInfo?.ScriptName;
             }
             else
             {
-                this.ScriptPath = originalEvent.InvocationInfo.ScriptName;
+                this.ScriptPath = originalEvent.InvocationInfo?.ScriptName;
             }
 
             this.OriginalEvent = originalEvent;

src/PowerShellEditorServices/Services/PowerShell/Debugging/PowerShellDebugContext.cs

@@ -159,7 +159,7 @@ private void RaiseDebuggerStoppedEvent()
         {
             if (!IsDebugServerActive)
             {
-                _languageServer.SendNotification("powerShell/startDebugger");
+                _languageServer?.SendNotification("powerShell/startDebugger");
             }
 
             DebuggerStopped?.Invoke(this, LastStopEventArgs);

test/PowerShellEditorServices.Test/Debugging/DebugServiceTests.cs

@@ -53,7 +53,8 @@ public DebugServiceTests()
 
             debugService = new DebugService(
                 _psesHost,
-                new PowerShellDebugContext(NullLoggerFactory.Instance, null, _psesHost),
+                _psesHost.DebugContext,
+                // new PowerShellDebugContext(NullLoggerFactory.Instance, null, _psesHost),
                 null,
                 new BreakpointService(
                     NullLoggerFactory.Instance,
@@ -1029,7 +1030,15 @@ private void AssertDebuggerStopped(
                 debuggerStoppedQueue.Take(new CancellationTokenSource(10000).Token);
 
             // TODO: Why does the casing of the path change? Specifically the Drive letter on Windows.
-            Assert.Equal(scriptPath.ToLower(), eventArgs.ScriptPath.ToLower());
+            if (eventArgs.ScriptPath is not null)
+            {
+                Assert.Equal(scriptPath.ToLower(), eventArgs.ScriptPath.ToLower());
+            }
+            else
+            {
+                Assert.Equal("", scriptPath);
+            }
+
             if (lineNumber > -1)
             {
                 Assert.Equal(lineNumber, eventArgs.LineNumber);