Treat unforwarded CancellationToken as error (and fix)

Author: andyleejordan

.editorconfig

@@ -21,14 +21,16 @@ dotnet_diagnostic.CS0169.severity = error
 dotnet_diagnostic.CS0219.severity = error
 # CS0414: The private field 'field' is assigned but its value is never used
 dotnet_diagnostic.CS0414.severity = error
-# CA2007: Do not directly await a Task
-dotnet_diagnostic.CA2007.severity = error
 # CA1068: CancellationToken parameters must come last
 dotnet_diagnostic.CA1068.severity = error
 # CA1822: Mark members as static
 dotnet_diagnostic.CA1822.severity = error
 # CA1823: Avoid unused private fields
 dotnet_diagnostic.CA1823.severity = error
+# CA2007: Do not directly await a Task
+dotnet_diagnostic.CA2007.severity = error
+# CA2016: Forward the CancellationToken parameter to methods that take one
+dotnet_diagnostic.CA2016.severity = error
 # All maintainability issues (dead code etc.)
 # See: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/maintainability-warnings
 dotnet_analyzer_diagnostic.category-Maintainability.severity = error

src/PowerShellEditorServices/Services/DebugAdapter/Handlers/DisconnectHandler.cs

@@ -75,7 +75,7 @@ public async Task<DisconnectResponse> Handle(DisconnectArguments request, Cancel
 
 #pragma warning disable CS4014
             // Trigger the clean up of the debugger. No need to wait for it.
-            Task.Run(_psesDebugServer.OnSessionEnded);
+            Task.Run(_psesDebugServer.OnSessionEnded, cancellationToken);
 #pragma warning restore CS4014
 
             return new DisconnectResponse();

src/PowerShellEditorServices/Services/DebugAdapter/Handlers/StackTraceHandler.cs

@@ -30,7 +30,7 @@ public StackTraceHandler(
         public Task<StackTraceResponse> Handle(StackTraceArguments request, CancellationToken cancellationToken)
         {
             StackFrameDetails[] stackFrameDetails =
-                _debugService.GetStackFrames();
+                _debugService.GetStackFrames(cancellationToken);
 
             // Handle a rare race condition where the adapter requests stack frames before they've
             // begun building.

src/PowerShellEditorServices/Services/PowerShellContext/Console/ConsoleReadLine.cs

@@ -216,7 +216,7 @@ internal async Task<string> InvokeLegacyReadLineAsync(bool isCommandLine, Cancel
                             }
                             else
                             {
-                                using (RunspaceHandle runspaceHandle = await this.powerShellContext.GetRunspaceHandleAsync().ConfigureAwait(false))
+                                using (RunspaceHandle runspaceHandle = await this.powerShellContext.GetRunspaceHandleAsync(cancellationToken) .ConfigureAwait(false))
                                 using (PowerShell powerShell = PowerShell.Create())
                                 {
                                     powerShell.Runspace = runspaceHandle.Runspace;

src/PowerShellEditorServices/Services/PowerShellContext/Console/UnixConsoleOperations.cs

@@ -264,7 +264,7 @@ private static Task<bool> SpinUntilKeyAvailableAsync(int millisecondsTimeout, Ca
                         s_waitHandle.Wait(ShortWaitForKeySpinUntilSleepTime, cancellationToken);
                         return IsKeyAvailable(cancellationToken);
                     },
-                    millisecondsTimeout));
+                    millisecondsTimeout), cancellationToken);
         }
 
         private static bool IsKeyAvailable(CancellationToken cancellationToken)

src/PowerShellEditorServices/Services/Symbols/Vistors/AstOperations.cs

@@ -62,7 +62,7 @@ public static async Task<CommandCompletion> GetCompletionsAsync(
             ILogger logger,
             CancellationToken cancellationToken)
         {
-            if (!s_completionHandle.Wait(0))
+            if (!s_completionHandle.Wait(0, cancellationToken))
             {
                 return null;
             }