Apply suggestions from code review

Co-authored-by: Robert Holt <[email protected]>

Author: andyleejordan

src/PowerShellEditorServices/Services/Analysis/AnalysisService.cs

@@ -225,13 +225,8 @@ public async Task<string> GetCommentHelpText(string functionText, string helpLoc
         /// <returns>A threadsafe readonly dictionary of the code actions of the particular file.</returns>
         public async Task<IReadOnlyDictionary<string, MarkerCorrection>> GetMostRecentCodeActionsForFileAsync(DocumentUri uri)
         {
-            ScriptFile file = null;
-            if (!_workspaceService.TryGetFile(uri, out file))
-            {
-                return null;
-            }
-
-            if (!_mostRecentCorrectionsByFile.TryGetValue(file, out CorrectionTableEntry corrections))
+            if (!_workspaceService.TryGetFile(uri, out ScriptFile file)
+                || !_mostRecentCorrectionsByFile.TryGetValue(file, out CorrectionTableEntry corrections))
             {
                 return null;
             }

src/PowerShellEditorServices/Services/TextDocument/Handlers/CodeActionHandler.cs

@@ -57,8 +57,9 @@ public override async Task<CommandOrCodeActionContainer> Handle(CodeActionParams
                 return Array.Empty<CommandOrCodeAction>();
             }
 
-            IReadOnlyDictionary<string, MarkerCorrection> corrections = await
-                _analysisService.GetMostRecentCodeActionsForFileAsync(request.TextDocument.Uri).ConfigureAwait(false);
+            IReadOnlyDictionary<string, MarkerCorrection> corrections = await _analysisService.GetMostRecentCodeActionsForFileAsync(
+                request.TextDocument.Uri)
+                .ConfigureAwait(false);
 
             if (corrections == null)
             {

src/PowerShellEditorServices/Services/Workspace/Handlers/ConfigurationHandler.cs

@@ -156,13 +156,13 @@ await _powerShellContextService.SetWorkingDirectoryAsync(
 
         private void SendFeatureChangesTelemetry(LanguageServerSettingsWrapper incomingSettings)
         {
-            var configChanges = new Dictionary<string, bool>();
-            if (incomingSettings == null)
+            if (incomingSettings is null)
             {
                 this._logger.LogTrace("Incoming settings were null");
                 return;
             }
 
+            var configChanges = new Dictionary<string, bool>();
             // Send telemetry if the user opted-out of ScriptAnalysis
             if (incomingSettings.Powershell.ScriptAnalysis.Enable == false &&
                 _configurationService.CurrentSettings.ScriptAnalysis.Enable != incomingSettings.Powershell.ScriptAnalysis.Enable)