Merge pull request #445 from PowerShell/AvoidShouldContinueWithoutForceFixBranch

Fix to consider the usage of [switch] type along with [boolean] for proper SupportsShouldContinue use

Author: raghushantha

Rules/AvoidShouldContinueWithoutForce.cs

@@ -46,7 +46,8 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
                 foreach (ParameterAst paramAst in paramAsts)
                 {
                     if (String.Equals(paramAst.Name.VariablePath.ToString(), "force", StringComparison.OrdinalIgnoreCase)
-                        && String.Equals(paramAst.StaticType.FullName, "System.Boolean", StringComparison.OrdinalIgnoreCase))
+                        && (String.Equals(paramAst.StaticType.FullName, "System.Boolean", StringComparison.OrdinalIgnoreCase) 
+                        || String.Equals(paramAst.StaticType.FullName, "System.Management.Automation.SwitchParameter", StringComparison.OrdinalIgnoreCase)))
                     {
                         hasForce = true;
                         break;

Tests/Rules/GoodCmdlet.ps1

@@ -275,4 +275,17 @@ function Get-Reserved*
 function Get-MyWidgetStatus
 {
 
+}
+
+function Get-MyFood
+{
+    [CmdletBinding(SupportsShouldProcess=$true)]
+    param([Switch]$Force)
+
+    process
+    {
+        if ($PSCmdlet.ShouldContinue("Are you sure?"))
+        {
+        }
+    }
 }