Fixes @splatting in double quoted strings (#165)

* fixes #149, #164
remove #variable from #doubleQuotedString, remove @ from #variableNoProperty

* add tests: no @splats in double quoted strings

Author: msftrncs

PowerShellSyntax.tmLanguage

@@ -1393,7 +1393,7 @@
 						</dict>
 					</dict>
 					<key>match</key>
-					<string>(?i:(\$|@)(global|local|private|script|using|workflow):((?:\p{L}|\d|_)+))</string>
+					<string>(?i:(\$)(global|local|private|script|using|workflow):((?:\p{L}|\d|_)+))</string>
 				</dict>
 				<dict>
 					<key>captures</key>
@@ -1592,10 +1592,6 @@
 					<key>include</key>
 					<string>#variableNoProperty</string>
 				</dict>
-				<dict>
-					<key>include</key>
-					<string>#variable</string>
-				</dict>
 				<dict>
 					<key>include</key>
 					<string>#doubleQuotedStringEscapes</string>

spec/testfiles/syntax_test_TheBigTestFile.ps1

@@ -173,6 +173,12 @@ $variable.Name
 #                                       ^^^^^^^^^^^^ variable.other.readwrite.powershell
 #                                                    ^ punctuation.definition.string.end.powershell
 
+# @splat references only work in argument mode, should not highlight in strings
+"This is a @double quoted string."
+# ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ string.quoted.double.powershell
+#          ^ not:punctuation.definition.variable.powershell
+#           ^ not:variable.other.readwrite.powershell
+
 # Single quotes string
 'This is a string'
 # <- punctuation.definition.string.begin.powershell string.quoted.single.powershell
@@ -369,6 +375,9 @@ $This is a 'double quoted'
 # <- punctuation.definition.variable.powershell
 # ^ string.quoted.double.heredoc.powershell support.variable.automatic.powershell
 Isn't it "nice"??
+There is no @platting here!
+#           ^ not:punctuation.definition.variable.powershell
+#            ^ not:variable.other.readwrite.powershell
 "@
 # <- string.quoted.double.heredoc.powershell
  # <- string.quoted.double.heredoc.powershell