Skip to content

fix: ensure event listeners are registered within service provider #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2024
Merged

fix: ensure event listeners are registered within service provider #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd590cd
chore: add test for service provider event registration
oaklees May 24, 2024
f697a5f
fix: call register within event service provider
oaklees May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/EventServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ class EventServiceProvider extends ServiceProvider
*/
public function register()
{
parent::register();

$this->registerSnsBroadcaster();

$this->registerSqsSnsQueueConnector();
Expand Down
20 changes: 20 additions & 0 deletions tests/EventServiceProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace PodPoint\AwsPubSub\Tests;

use Illuminate\Support\Facades\Event;
use PodPoint\AwsPubSub\EventServiceProvider;

class EventServiceProviderTest extends TestCase
Expand Down Expand Up @@ -128,4 +129,23 @@ public function it_can_make_sure_some_aws_credentials_are_provided_and_valid(arr
$this->assertArrayHasKey('foo', $config);
$this->assertArrayNotHasKey('credentials', $config);
}

/**
* @test
*/
public function it_can_register_listeners_when_listen_array_is_populated()
{
$this->app->register(TestPubSubEventServiceProvider::class);

$this->assertCount(1, Event::getListeners('foo'));
$this->assertCount(2, Event::getListeners('bar'));
}
}

class TestPubSubEventServiceProvider extends EventServiceProvider
{
protected $listen = [
'foo' => ['bar'],
'bar' => ['baz', 'qux'],
];
}