Skip to content

Commit 1554545

Browse files
committed
fix(connect-react): fix one "maximum update depth exceeded" (1.0.0-preview.14)
1 parent 441847a commit 1554545

File tree

4 files changed

+12
-10
lines changed

4 files changed

+12
-10
lines changed

packages/connect-react/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
<!-- markdownlint-disable MD024 -->
22
# Changelog
33

4+
# [1.0.0-preview.14] - 2024-12-17
5+
6+
- Fixed one case of "maximum update depth exceeded" (useEffect component dependency)
7+
48
# [1.0.0-preview.13] - 2024-12-17
59

610
- Added skippable prop types to support triggers

packages/connect-react/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@pipedream/connect-react",
3-
"version": "1.0.0-preview.13",
3+
"version": "1.0.0-preview.14",
44
"description": "Pipedream Connect library for React",
55
"files": [
66
"dist"

packages/connect-react/src/hooks/form-context.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ export const FormContextProvider = <T extends ConfigurableProps>({
100100
useEffect(() => {
101101
setEnabledOptionalProps({});
102102
}, [
103-
component,
103+
component.key,
104104
]);
105105
// XXX pass this down? (in case we make it hash or set backed, but then also provide {add,remove} instead of set)
106106
const optionalPropIsEnabled = (prop: ConfigurableProp) => enabledOptionalProps[prop.name];

pnpm-lock.yaml

Lines changed: 6 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)