diff --git a/photon-core/src/main/java/org/photonvision/common/configuration/SqlConfigProvider.java b/photon-core/src/main/java/org/photonvision/common/configuration/SqlConfigProvider.java index b9c6c17ec8..f341954aca 100644 --- a/photon-core/src/main/java/org/photonvision/common/configuration/SqlConfigProvider.java +++ b/photon-core/src/main/java/org/photonvision/common/configuration/SqlConfigProvider.java @@ -649,7 +649,7 @@ private HashMap loadCameraConfigs(Connection conn) JacksonUtils.deserialize( result.getString(Columns.CAM_PIPELINE_JSONS), dummyList.getClass()); - List loadedSettings = new ArrayList<>(); + List loadedSettings = new ArrayList<>(pipelineSettings.size()); for (var setting : pipelineSettings) { if (setting instanceof String str) { loadedSettings.add(JacksonUtils.deserialize(str, CVPipelineSettings.class)); diff --git a/photon-core/src/main/java/org/photonvision/common/hardware/GPIO/pi/PigpioSocket.java b/photon-core/src/main/java/org/photonvision/common/hardware/GPIO/pi/PigpioSocket.java index f495a9d510..62cafc63eb 100644 --- a/photon-core/src/main/java/org/photonvision/common/hardware/GPIO/pi/PigpioSocket.java +++ b/photon-core/src/main/java/org/photonvision/common/hardware/GPIO/pi/PigpioSocket.java @@ -190,7 +190,7 @@ private void addBlinkPulsesToWaveform(int pulseTimeMillis, int blinks, int pinNo } try { - ArrayList pulses = new ArrayList<>(); + ArrayList pulses = new ArrayList<>(blinks * 2); var startPulse = new PigpioPulse(pinNo, 0, pulseTimeMillis * 1000); var endPulse = new PigpioPulse(0, pinNo, pulseTimeMillis * 1000); diff --git a/photon-core/src/main/java/org/photonvision/common/hardware/VisionLED.java b/photon-core/src/main/java/org/photonvision/common/hardware/VisionLED.java index 2a1af50868..891b23e4a2 100644 --- a/photon-core/src/main/java/org/photonvision/common/hardware/VisionLED.java +++ b/photon-core/src/main/java/org/photonvision/common/hardware/VisionLED.java @@ -36,7 +36,7 @@ public class VisionLED { private static final Logger logger = new Logger(VisionLED.class, LogGroup.VisionModule); private final int[] ledPins; - private final List visionLEDs = new ArrayList<>(); + private final List visionLEDs; private final int brightnessMin; private final int brightnessMax; private final PigpioSocket pigpioSocket; @@ -58,7 +58,8 @@ public VisionLED( this.brightnessMax = brightnessMax; this.pigpioSocket = pigpioSocket; this.modeConsumer = visionLEDmode; - this.ledPins = ledPins.stream().mapToInt(i -> i).toArray(); + this.ledPins = ledPins.stream().mapToInt(Integer::intValue).toArray(); + visionLEDs = new ArrayList<>(this.ledPins.length); ledPins.forEach( pin -> { if (Platform.isRaspberryPi()) { diff --git a/photon-core/src/main/java/org/photonvision/vision/objects/Letterbox.java b/photon-core/src/main/java/org/photonvision/vision/objects/Letterbox.java index 51cf489157..4965a9b83d 100644 --- a/photon-core/src/main/java/org/photonvision/vision/objects/Letterbox.java +++ b/photon-core/src/main/java/org/photonvision/vision/objects/Letterbox.java @@ -86,7 +86,7 @@ public static Letterbox letterbox(Mat frame, Mat letterboxed, Size newShape, Sca * @return The resized detections */ public List resizeDetections(List unscaled) { - var ret = new ArrayList(); + var ret = new ArrayList(unscaled.size()); for (var t : unscaled) { var scale = 1.0 / this.scale; diff --git a/photon-core/src/main/java/org/photonvision/vision/pipe/impl/Calibrate3dPipe.java b/photon-core/src/main/java/org/photonvision/vision/pipe/impl/Calibrate3dPipe.java index bfa96c5a3f..7f8401cc18 100644 --- a/photon-core/src/main/java/org/photonvision/vision/pipe/impl/Calibrate3dPipe.java +++ b/photon-core/src/main/java/org/photonvision/vision/pipe/impl/Calibrate3dPipe.java @@ -400,7 +400,7 @@ private List createObservations( } var img_pts_reprojected_list = img_pts_reprojected.toList(); - var reprojectionError = new ArrayList(); + var reprojectionError = new ArrayList(img_pts_reprojected_list.size()); for (int j = 0; j < img_pts_reprojected_list.size(); j++) { // error = (measured - expected) var measured = img_pts_reprojected_list.get(j); diff --git a/photon-core/src/main/java/org/photonvision/vision/pipe/impl/Collect2dTargetsPipe.java b/photon-core/src/main/java/org/photonvision/vision/pipe/impl/Collect2dTargetsPipe.java index 836e04fc7f..90910c5cf9 100644 --- a/photon-core/src/main/java/org/photonvision/vision/pipe/impl/Collect2dTargetsPipe.java +++ b/photon-core/src/main/java/org/photonvision/vision/pipe/impl/Collect2dTargetsPipe.java @@ -37,7 +37,7 @@ public class Collect2dTargetsPipe */ @Override protected List process(List in) { - List targets = new ArrayList<>(); + List targets = new ArrayList<>(in.size()); var calculationParams = new TrackedTarget.TargetCalculationParameters(