Skip to content

Conversation

@Sovietianqi
Copy link
Contributor

I had to submit this pull request again because the previous two were accidentally closed due to my mistakes. As the Chinese saying goes, 'Third time’s the charm' (or literally 'Things should not be attempted more than three times'). I hope I won’t make the same silly mistake again this time.

@Sovietianqi Sovietianqi changed the title Fix the issue where Ares' "Flash.Duration" cannot override the weapon's repair flash effect. [Minor] Fix the issue where Ares' "Flash.Duration" cannot override the weapon's repair flash effect. Aug 16, 2025
@github-actions github-actions bot added the Minor Minor feature and/or fix, not a lot of changes or they are not significant label Aug 16, 2025
@github-actions
Copy link

github-actions bot commented Sep 12, 2025

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@DeathFishAtEase DeathFishAtEase added No Documentation Needed No documentation needed whatsoever Minor Minor feature and/or fix, not a lot of changes or they are not significant and removed Minor Minor feature and/or fix, not a lot of changes or they are not significant No Documentation Needed No documentation needed whatsoever labels Oct 5, 2025
@Coronia Coronia added the No Documentation Needed No documentation needed whatsoever label Oct 8, 2025
Copy link
Contributor

@Coronia Coronia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since there're only some minor codestyle issues, gonna merge it first and fix those issues in another commit

@Coronia Coronia merged commit 3a59e61 into Phobos-developers:develop Oct 8, 2025
7 of 9 checks passed
@Sovietianqi
Copy link
Contributor Author

The inspiration for this modification and some of the code come from @DeathFishAtEase ,and their authorization has been obtained. Thanks to them.

DeathFishAtEase added a commit to DeathFishAtEase/Phobos that referenced this pull request Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Minor Minor feature and/or fix, not a lot of changes or they are not significant No Documentation Needed No documentation needed whatsoever

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants