From c377a4e196cd5456a83ee9deb14b54f07276be33 Mon Sep 17 00:00:00 2001 From: Karl Williamson Date: Sat, 24 May 2025 08:39:45 -0600 Subject: [PATCH] Mark do_open(), do_openn() as internal, not public These undocumented functions have exactly 0 uses on CPAN. do_open() is mentioned in 7 distributions. In all cases it is to #undef the macro name because it was polluting the distro's name space which has its own function named do_open(). --- embed.fnc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/embed.fnc b/embed.fnc index 762f47f06c63..08a3aab4878f 100644 --- a/embed.fnc +++ b/embed.fnc @@ -1049,7 +1049,7 @@ Rp |I32 |do_ncmp |NN SV * const left \ Cp |void |do_op_dump |I32 level \ |NN PerlIO *file \ |NULLOK const OP *o -AMbp |bool |do_open |NN GV *gv \ +CMbp |bool |do_open |NN GV *gv \ |NN const char *name \ |I32 len \ |int as_raw \ @@ -1062,7 +1062,7 @@ px |bool |do_open6 |NN GV *gv \ |NULLOK PerlIO *supplied_fp \ |NULLOK SV **svp \ |U32 num -Ap |bool |do_openn |NN GV *gv \ +Cp |bool |do_openn |NN GV *gv \ |NN const char *oname \ |I32 len \ |int as_raw \