Skip to content

Commit fcfe20c

Browse files
committed
fixes: I now always define SvVOK(), so depend on SvVSTRING_mg instead
and implement the skip if the vstring doeesn't compile vstrings were originally added in perl-5.8.0-82-g92f0c26562, SvVSTRING_mg() was originally added in perl-5.8.0-8018-gb0a11fe104 so technically in the same release. I expect there were some uses of intermediate versions 19 years ago, but I don't think we need to worry about it now. (to be squashed)
1 parent 8275f5f commit fcfe20c

File tree

1 file changed

+3
-1
lines changed
  • dist/Devel-PPPort/parts/inc

1 file changed

+3
-1
lines changed

dist/Devel-PPPort/parts/inc/magic

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ __UNDEFINED__ SvVOK(sv) (FALSE)
267267
const char *
268268
sv_vstring_get(pTHX_ SV *sv, STRLEN *lenp)
269269
{
270-
#ifdef SvVOK
270+
#ifdef SvVSTRING_mg
271271
MAGIC *mg = SvVSTRING_mg(sv);
272272
if (!mg) return NULL;
273273

@@ -776,6 +776,8 @@ is tied($big)->{store}, 0;
776776
SKIP:
777777
{
778778
my $vstr = eval "v1.23.456";
779+
$vstr
780+
or skip "No vstrings", 2;
779781
ok Devel::PPPort::SvVOK($vstr), '$vstr has SvVOK';
780782
is Devel::PPPort::SvVSTRING($vstr), "v1.23.456", 'SvVSTRING()';
781783
}

0 commit comments

Comments
 (0)