ParseXS: refactor: add OVERLOAD node

Add
     ExtUtils::ParseXS::Node::OVERLOAD

class, and add a basic test.

Note that currently this code doesn't warn about duplicate op names (it
just silently skips duplicates), nor warn about unknown op names (it
happily accepts them). This commit preserves the current behaviour for
now.

Author: iabyn

dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm

@@ -2227,24 +2227,6 @@ sub INIT_handler {
 }
 
 
-# Add all overload method names, like 'cmp', '<=>', etc, (possibly
-# multiple ones per line) until the next keyword line, as 'seen' keys to
-# the $self->{xsub_map_overload_name_to_seen} hash.
-
-sub OVERLOAD_handler {
-  my ExtUtils::ParseXS $self = shift;
-  $_ = shift;
-
-  for (;  !/^$BLOCK_regexp/o;  $_ = shift(@{ $self->{line} })) {
-    next unless /\S/;
-    trim_whitespace($_);
-    while ( s/^\s*([\w:"\\)\+\-\*\/\%\<\>\.\&\|\^\!\~\{\}\=]+)\s*//) {
-      $self->{xsub_map_overload_name_to_seen}->{$1} = 1;
-    }
-  }
-}
-
-
 sub FALLBACK_handler {
   my ExtUtils::ParseXS $self = shift;
   my ($setting) = @_;

dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Node.pm

@@ -1836,6 +1836,34 @@ sub parse {
 }
 
 
+# ======================================================================
+
+package ExtUtils::ParseXS::Node::OVERLOAD;
+
+# Handle OVERLOAD keyword
+
+BEGIN { $build_subclass->('multiline_merged', # parent
+    'ops', # has ref of overloaded op names
+)};
+
+# Add all overload method names, like 'cmp', '<=>', etc, (possibly
+# multiple ones per line) until the next keyword line, as 'seen' keys to
+# the $self->{xsub_map_overload_name_to_seen} hash.
+
+sub parse {
+    my __PACKAGE__       $self = shift;
+    my ExtUtils::ParseXS $pxs  = shift;
+
+    $self->SUPER::parse($pxs); # set file/line_no, get lines, set text
+
+    my $s = $self->{text};
+    while ($s =~  s/^\s*([\w:"\\)\+\-\*\/\%\<\>\.\&\|\^\!\~\{\}\=]+)\s*//) {
+        $self->{ops}{$1} = 1;
+        $pxs->{xsub_map_overload_name_to_seen}->{$1} = 1;
+    }
+}
+
+
 # ======================================================================
 
 package ExtUtils::ParseXS::Node::ATTRS;

dist/ExtUtils-ParseXS/t/001-basic.t

@@ -3973,4 +3973,41 @@ EOF
 }
 
 
+{
+    # Test OVERLOAD keyword
+
+    my $preamble = Q(<<'EOF');
+        |MODULE = Foo PACKAGE = Foo
+        |
+        |PROTOTYPES:  DISABLE
+        |
+EOF
+
+    my @test_fns = (
+        [
+            "OVERLOAD basic",
+            [ Q(<<'EOF') ],
+                |void
+                |foo()
+                |    OVERLOAD:   cmp   <=>
+                |                  + - *    /
+                |    OVERLOAD:   >   <  >=
+EOF
+            [ 0, 0, qr{\Q"Foo::(*"},   "has Foo::(* method"   ],
+            [ 0, 0, qr{\Q"Foo::(+"},   "has Foo::(+ method"   ],
+            [ 0, 0, qr{\Q"Foo::(-"},   "has Foo::(- method"   ],
+            [ 0, 0, qr{\Q"Foo::(/"},   "has Foo::(/ method"   ],
+            [ 0, 0, qr{\Q"Foo::(<"},   "has Foo::(< method"   ],
+            [ 0, 0, qr{\Q"Foo::(<=>"}, "has Foo::(<=> method" ],
+            [ 0, 0, qr{\Q"Foo::(>"},   "has Foo::(> method"   ],
+            [ 0, 0, qr{\Q"Foo::(>="},  "has Foo::(>= method"  ],
+            [ 0, 0, qr{\Q"Foo::(cmp"}, "has Foo::(cmp method" ],
+        ],
+
+    );
+
+    test_many($preamble, 'boot_Foo', \@test_fns);
+}
+
+
 done_testing;