Skip to content

Commit 1ac4431

Browse files
PIG208gnprice
authored andcommitted
api: Mark GetServerSettingsResult.zulipMergeBase as required
See "Feature level 88" from Zulip API changelog: https://zulip.com/api/changelog This is one of the few places (along with registerQueue) where it's important that we smoothly handle attempting to connect to an ancient server where this field might indeed be missing. Happily, we do handle those since commit 733bb88 (zulip#1783).
1 parent 506b87a commit 1ac4431

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

lib/api/route/realm.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class GetServerSettingsResult {
3636

3737
final int zulipFeatureLevel;
3838
final String zulipVersion;
39-
final String? zulipMergeBase; // TODO(server-5)
39+
final String zulipMergeBase;
4040

4141
final bool pushNotificationsEnabled;
4242
final bool isIncompatible;

lib/api/route/realm.g.dart

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)