Skip to content

Conversation

Trainmaster
Copy link
Contributor

Description

This adds support for table indent (http://www.datypic.com/sc/ooxml/e-w_tblInd-1.html)

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have update the documentation to describe the changes

@Trainmaster
Copy link
Contributor Author

@troosan I'd suggest to remove the unit in the table style options and also use \PhpOffice\PhpWord\ComplexType\TblWidth for the width option. Imho it makes no sense to use the same unit for both table style options.

@Trainmaster Trainmaster force-pushed the feature-add-table-indent-option branch from da5d98d to 081c672 Compare April 11, 2018 08:07
@troosan
Copy link
Contributor

troosan commented Apr 14, 2018

Indeed, I agree, it makes sense to use the TblWidth everywhere.
If you do the change, make sure you keep the getters/setters to keep backward compatibility.
Just mark them as deprecated so we do not forget to remove them in version 1.0

@Trainmaster
Copy link
Contributor Author

@troosan Alright. But I'll do that in a separate pull request.

@troosan troosan added this to the v0.15.0 milestone Apr 15, 2018
@troosan troosan merged commit 84fa440 into PHPOffice:develop Apr 25, 2018
@Trainmaster Trainmaster deleted the feature-add-table-indent-option branch May 23, 2018 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants