Skip to content

Commit d958137

Browse files
committed
Improve AddfileTest based on code review suggestions
- Make all arrays in `dataAddFile` multi-line arrays for consistency. - Use an instance of `File` instead of `stdClass` to avoid issues in PHPCS 4 as it declares the type of the parameters in the `FileList::addFile()` method signature.
1 parent 983ec6a commit d958137

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

tests/Core/Files/FileList/AddFileTest.php

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,11 @@
88

99
namespace PHP_CodeSniffer\Tests\Core\Files\FileList;
1010

11+
use PHP_CodeSniffer\Files\File;
1112
use PHP_CodeSniffer\Files\FileList;
13+
use PHP_CodeSniffer\Ruleset;
1214
use PHP_CodeSniffer\Tests\ConfigDouble;
1315
use PHPUnit\Framework\TestCase;
14-
use stdClass;
1516

1617
/**
1718
* Tests for the \PHP_CodeSniffer\Files\FileList::addFile method.
@@ -90,12 +91,19 @@ public function testAddFile($fileName, $fileObject=null)
9091
*/
9192
public static function dataAddFile()
9293
{
94+
$config = new ConfigDouble();
95+
$ruleset = new Ruleset($config);
96+
9397
return [
94-
'Regular file' => ['fileName' => 'test1.php'],
95-
'STDIN' => ['fileName' => 'STDIN'],
98+
'Regular file' => [
99+
'fileName' => 'test1.php',
100+
],
101+
'STDIN' => [
102+
'fileName' => 'STDIN',
103+
],
96104
'Regular file with file object' => [
97105
'fileName' => 'test1.php',
98-
'fileObject' => new stdClass(),
106+
'fileObject' => new File('test1.php', $ruleset, $config),
99107
],
100108
];
101109

0 commit comments

Comments
 (0)