Enable clang check for documentation syntax. Update pimpls for external headers

Author: Roberto Di Remigio

cmake/compilers/CXXFlags.cmake

@@ -44,7 +44,7 @@ if(NOT DEFINED DEFUALT_CXX_FLAGS_SET OR RESET_FLAGS)
       else()
           set(CMAKE_CXX_FLAGS "-fPIC -std=gnu++98")
       endif()
-      set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g3 -DDEBUG -Wall -Wextra -Winit-self -Woverloaded-virtual -Wuninitialized -Wmissing-declarations -Wwrite-strings -Weffc++")
+      set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g3 -DDEBUG -Wall -Wextra -Winit-self -Woverloaded-virtual -Wuninitialized -Wmissing-declarations -Wwrite-strings -Weffc++ -Wdocumentation")
       set(CMAKE_CXX_FLAGS_RELEASE "-O3 -DNDEBUG -Wno-unused")
       if(ENABLE_CODE_COVERAGE)
           set(CMAKE_CXX_FLAGS

src/utils/EigenPimpl.hpp

@@ -2,18 +2,27 @@
 #define EIGENPIMPL_HPP
 
 // Disable obnoxious warnings from Eigen headers
-#if defined (__GNUC__)
+#if (defined(__GNUC__) || defined(__GNUG__)) && !(defined(__clang__) || defined(__INTEL_COMPILER))
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wall"
 #pragma GCC diagnostic ignored "-Weffc++"
 #pragma GCC diagnostic ignored "-Wextra"
 #include <Eigen/Dense>
 #pragma GCC diagnostic pop
-#elif (__INTEL_COMPILER)
+#elif defined(__ICC) || defined(__INTEL_COMPILER)
 #pragma warning push
 #pragma warning disable "-Wall"
 #include <Eigen/Dense>
 #pragma warning pop
+#elif defined(__clang__)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wall"
+#pragma clang diagnostic ignored "-Weffc++"
+#pragma clang diagnostic ignored "-Wextra"
+#pragma clang diagnostic ignored "-Wdocumentation"
+#pragma clang diagnostic ignored "-Wdeprecated-register"
+#include <Eigen/Dense>
+#pragma clang diagnostic pop
 #endif
 
 #endif // EIGENPIMPL_HPP

src/utils/GetkwPimpl.hpp

@@ -2,18 +2,27 @@
 #define GETKWPIMPL_HPP
 
 // Disable obnoxious warnings from Getkw headers
-#if defined (__GNUC__)
+#if (defined(__GNUC__) || defined(__GNUG__)) && !(defined(__clang__) || defined(__INTEL_COMPILER))
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wall"
 #pragma GCC diagnostic ignored "-Weffc++"
 #pragma GCC diagnostic ignored "-Wextra"
 #include "Getkw.h"
 #pragma GCC diagnostic pop
-#elif (__INTEL_COMPILER)
+#elif defined(__ICC) || defined(__INTEL_COMPILER)
 #pragma warning push
 #pragma warning disable "-Wall"
 #include "Getkw.h"
 #pragma warning pop
+#elif defined(__clang__)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wall"
+#pragma clang diagnostic ignored "-Weffc++"
+#pragma clang diagnostic ignored "-Wextra"
+#pragma clang diagnostic ignored "-Wdocumentation"
+#pragma clang diagnostic ignored "-Wdeprecated-register"
+#include "Getkw.h"
+#pragma clang diagnostic pop
 #endif
 
 #endif // GETKWPIMPL_HPP

src/utils/TaylorPimpl.hpp

@@ -1,19 +1,28 @@
 #ifndef TAYLORPIMPL_HPP
 #define TAYLORPIMPL_HPP
 
-// Disable obnoxious warnings from Eigen headers
-#if defined (__GNUC__)
+// Disable obnoxious warnings from libtaylor headers
+#if (defined(__GNUC__) || defined(__GNUG__)) && !(defined(__clang__) || defined(__INTEL_COMPILER))
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wall"
 #pragma GCC diagnostic ignored "-Weffc++"
 #pragma GCC diagnostic ignored "-Wextra"
 #include "taylor.hpp" 
 #pragma GCC diagnostic pop
-#elif (__INTEL_COMPILER)
+#elif defined(__ICC) || defined(__INTEL_COMPILER)
 #pragma warning push
 #pragma warning disable "-Wall"
 #include "taylor.hpp" 
 #pragma warning pop
+#elif defined(__clang__)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wall"
+#pragma clang diagnostic ignored "-Weffc++"
+#pragma clang diagnostic ignored "-Wextra"
+#pragma clang diagnostic ignored "-Wdocumentation"
+#pragma clang diagnostic ignored "-Wdeprecated-register"
+#include "taylor.hpp" 
+#pragma clang diagnostic pop
 #endif
 
 #endif // TAYLORPIMPL_HPP