Skip to content

Add extra test for OETH Withdraw Queue #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Add extra test for OETH Withdraw Queue #2142

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45fa9cb
test: add tests for `_allocate()`.
clement-ux Jul 17, 2024
6a81c23
test: more test.
clement-ux Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
191 changes: 191 additions & 0 deletions contracts/test/vault/oeth-vault.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,197 @@ describe("OETH Vault", function () {
});
});

describe("Allocate", () => {
const delayPeriod = 10 * 60; // 10mins
it("Shouldn't allocate as minted amount is lower than autoAllocateThreshold", async () => {
const { oethVault, weth, daniel } = fixture;

// Set auto allocate threshold to 100 WETH
await oethVault
.connect(await impersonateAndFund(await oethVault.governor()))
.setAutoAllocateThreshold(oethUnits("100"));

// Mint for 10 WETH
const tx = oethVault
.connect(daniel)
.mint(weth.address, oethUnits("10"), "0");

await expect(tx).to.not.emit(oethVault, "AssetAllocated");
});
it("Shouldn't allocate as no WETH available", async () => {
const { oethVault, weth, daniel } = fixture;

// Deploy default strategy
const mockStrategy = await deployWithConfirmation("MockStrategy");
await oethVault
.connect(await impersonateAndFund(await oethVault.governor()))
.approveStrategy(mockStrategy.address);
await oethVault
.connect(await impersonateAndFund(await oethVault.governor()))
.setAssetDefaultStrategy(weth.address, mockStrategy.address);

// Mint will allocate all to default strategy bc no buffer, no threshold
await oethVault.connect(daniel).mint(weth.address, oethUnits("10"), "0");
await oethVault.connect(daniel).requestWithdrawal(oethUnits("5"));

// Deposit less than queued amount (5 WETH) => _wethAvailable() return 0
const tx = oethVault
.connect(daniel)
.mint(weth.address, oethUnits("3", "0"));
expect(tx).to.not.emit(oethVault, "AssetAllocated");
});
it("Shouldn't allocate as WETH available is lower than buffer", async () => {
const { oethVault, weth, daniel } = fixture;

await oethVault.connect(daniel).mint(weth.address, oethUnits("100"), "0");

// Set vault buffer to 5%
await oethVault
.connect(await impersonateAndFund(await oethVault.governor()))
.setVaultBuffer(oethUnits("0.05"));

// OETH total supply = 100(first deposit) + 5(second deposit) = 105
// Buffer = 105 * 5% = 5.25 WETH
// Second deposit should remain in the vault as below vault buffer
const tx = oethVault.connect(daniel).mint(oethUnits("5"), "0");
expect(tx).to.not.emit(oethVault, "AssetAllocated");
});
it("Shouldn't allocate as default strategy is address null", async () => {
const { oethVault, weth, daniel } = fixture;

const tx = oethVault
.connect(daniel)
.mint(weth.address, oethUnits("100"), "0");

expect(tx).to.not.emit(oethVault, "AssetAllocated");
});
describe("Should allocate WETH available to default strategy when: ", () => {
let mockStrategy;
beforeEach(async () => {
// Deploy default strategy
const { oethVault, weth } = fixture;
mockStrategy = await deployWithConfirmation("MockStrategy");
await oethVault
.connect(await impersonateAndFund(await oethVault.governor()))
.approveStrategy(mockStrategy.address);
await oethVault
.connect(await impersonateAndFund(await oethVault.governor()))
.setAssetDefaultStrategy(weth.address, mockStrategy.address);
});
it("buffer is 0%, 0 WETH in queue", async () => {
const { oethVault, daniel, weth } = fixture;
const tx = oethVault
.connect(daniel)
.mint(weth.address, oethUnits("10"), "0");
await expect(tx)
.to.emit(oethVault, "AssetAllocated")
.withArgs(weth.address, mockStrategy.address, oethUnits("10"));
expect(await weth.balanceOf(mockStrategy.address)).to.be.equal(
oethUnits("10")
);
});
it("buffer is 5%", async () => {
const { oethVault, daniel, weth } = fixture;
// Set vault buffer to 5%
await oethVault
.connect(await impersonateAndFund(await oethVault.governor()))
.setVaultBuffer(oethUnits("0.05"));

const tx = oethVault
.connect(daniel)
.mint(weth.address, oethUnits("10"), "0");
await expect(tx)
.to.emit(oethVault, "AssetAllocated")
.withArgs(weth.address, mockStrategy.address, oethUnits("9.5"));
expect(await weth.balanceOf(mockStrategy.address)).to.be.equal(
oethUnits("9.5")
);
});
it("buffer is 0%, 10 WETH in queue", async () => {
const { oethVault, daniel, weth } = fixture;
await oethVault
.connect(daniel)
.mint(weth.address, oethUnits("10"), "0");
await oethVault.connect(daniel).requestWithdrawal(oethUnits("10"));
const tx = oethVault
.connect(daniel)
.mint(weth.address, oethUnits("20"), "0");

// 10 WETH in the queue, 10 WETH in strat. New deposit of 20, only 10 WETH available to allocate to strategy.
await expect(tx)
.to.emit(oethVault, "AssetAllocated")
.withArgs(weth.address, mockStrategy.address, oethUnits("10"));
expect(await weth.balanceOf(mockStrategy.address)).to.be.equal(
oethUnits("20")
);
});
it("buffer is 0%, 20 WETH in queue, 10 WETH claimed", async () => {
const { oethVault, daniel, weth } = fixture;
await oethVault
.connect(daniel)
.mint(weth.address, oethUnits("30"), "0");
await oethVault.connect(daniel).requestWithdrawal(oethUnits("10"));
await advanceTime(delayPeriod);
// Simulate strategist pulling back WETH to the vault.
await weth
.connect(await impersonateAndFund(mockStrategy.address))
.transfer(oethVault.address, oethUnits("10"));
await oethVault.connect(daniel).claimWithdrawal(0);
// So far, 10 WETH queued, 10 WETH claimed, 0 WETH available, 20 WETH in strat

await oethVault.connect(daniel).requestWithdrawal(oethUnits("10"));
// So far, 20 WETH queued, 10 WETH claimed, 0 WETH available, 20 WETH in strat

// Deposit 35 WETH, 10 WETH should remain in the vault for withdraw, so strat should have 45WETH.
const tx = oethVault
.connect(daniel)
.mint(weth.address, oethUnits("35"), "0");
await expect(tx)
.to.emit(oethVault, "AssetAllocated")
.withArgs(weth.address, mockStrategy.address, oethUnits("25"));

expect(await weth.balanceOf(mockStrategy.address)).to.be.equal(
oethUnits("45")
);
});
it("buffer is 5%, 20 WETH in queue, 10 WETH claimed", async () => {
const { oethVault, daniel, weth } = fixture;
await oethVault
.connect(daniel)
.mint(weth.address, oethUnits("40"), "0");
await oethVault.connect(daniel).requestWithdrawal(oethUnits("10"));
await advanceTime(delayPeriod);
// Simulate strategist pulling back WETH to the vault.
await weth
.connect(await impersonateAndFund(mockStrategy.address))
.transfer(oethVault.address, oethUnits("10"));
await oethVault.connect(daniel).claimWithdrawal(0);
// So far, 10 WETH queued, 10 WETH claimed, 0 WETH available, 30 WETH in strat

await oethVault.connect(daniel).requestWithdrawal(oethUnits("10"));
// So far, 20 WETH queued, 10 WETH claimed, 0 WETH available, 30 WETH in strat

// Set vault buffer to 5%
await oethVault
.connect(await impersonateAndFund(await oethVault.governor()))
.setVaultBuffer(oethUnits("0.05"));

// Deposit 40 WETH, 10 WETH should remain in the vault for withdraw + 3 (i.e. 20+40 *5%)
// So strat should have 57WETH.
const tx = oethVault
.connect(daniel)
.mint(weth.address, oethUnits("40"), "0");
await expect(tx)
.to.emit(oethVault, "AssetAllocated")
.withArgs(weth.address, mockStrategy.address, oethUnits("27"));

expect(await weth.balanceOf(mockStrategy.address)).to.be.equal(
oethUnits("57")
);
});
});
});

describe("Withdrawal Queue", () => {
const delayPeriod = 10 * 60; // 10 minutes
describe("with all 60 WETH in the vault", () => {
Expand Down